pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
11 stars 1 forks source link

[patch] Rely on the base class to not mangle names by default #227

Closed liamhuber closed 6 months ago

liamhuber commented 7 months ago

This reverts #226 in the event that pyiron_base 1358 gets merged and the whole process is handled upstream.

github-actions[bot] commented 7 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/revert_mangleexploitation

codacy-production[bot] commented 7 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.00% (target: -1.00%) :white_check_mark:
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (b304c697774306185e1ef636c4c1b59cd3578e1a) | 3114 | 2702 | 86.77% | | | Head commit (c27d38f5147ddd8f5ed3cd577d0861590caf3f29) | 3113 (-1) | 2701 (-1) | 86.77% (**+0.00%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#227) | 0 | 0 | **∅ (not applicable)** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

liamhuber commented 6 months ago

This won't be necessary, the next version of base will jump straight to pyrion_base 1358, so we'll get the desired renaming behaviour by default and never need #226