pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
10 stars 1 forks source link

[minor] Semantics #244

Closed liamhuber closed 3 months ago

liamhuber commented 3 months ago

Breaking out responsibility for the label, parent/child relationships (including semantic uniqueness), path, root, etc. into separate classes. Long term, this is also useful for non-workflow/non-node semantic objects used to indicate non-data connections between workflows.

Part of #243

Only user-facing changes are that Composite.nodes got renamed to Composite.children and is a bidict instead of DotDict.

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 3 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyironworkflow/semantics

codacy-production[bot] commented 3 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.20% (target: -1.00%) :white_check_mark: 94.84%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (9d7b286298f0eeaea77e34f3a86ad42aa004db8d) | 3151 | 2734 | 86.77% | | | Head commit (72827593acfbee95736bc4692dbf4f34ec8c890d) | 3231 (+80) | 2810 (+76) | 86.97% (**+0.20%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#244) | 213 | 202 | **94.84%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 8333157217

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_workflow/semantics.py 171 183 93.44%
<!-- Total: 225 237 94.94% -->
Files with Coverage Reduction New Missed Lines %
meta.py 1 98.21%
macro.py 9 89.33%
workflow.py 13 79.78%
composite.py 22 90.3%
node.py 27 92.2%
<!-- Total: 72 -->
Totals Coverage Status
Change from base Build 8256110010: -0.03%
Covered Lines: 5996
Relevant Lines: 6534

💛 - Coveralls
liamhuber commented 3 months ago

Test failures were a timeout downloading from conda, I guess this is 100% on the GitHub side and will just re-run.

liamhuber commented 3 months ago

Faulty re-run button may be a browser version problem on my end; it worked fine in firefox