Closed liamhuber closed 3 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Coverage variation | Diff coverage |
---|---|
:white_check_mark: +0.20% (target: -1.00%) | :white_check_mark: 94.84% |
You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pyiron_workflow/semantics.py | 171 | 183 | 93.44% | ||
<!-- | Total: | 225 | 237 | 94.94% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
meta.py | 1 | 98.21% | ||
macro.py | 9 | 89.33% | ||
workflow.py | 13 | 79.78% | ||
composite.py | 22 | 90.3% | ||
node.py | 27 | 92.2% | ||
<!-- | Total: | 72 | --> |
Totals | |
---|---|
Change from base Build 8256110010: | -0.03% |
Covered Lines: | 5996 |
Relevant Lines: | 6534 |
Test failures were a timeout downloading from conda, I guess this is 100% on the GitHub side and will just re-run.
Faulty re-run button may be a browser version problem on my end; it worked fine in firefox
Breaking out responsibility for the label, parent/child relationships (including semantic uniqueness), path, root, etc. into separate classes. Long term, this is also useful for non-workflow/non-node semantic objects used to indicate non-data connections between workflows.
Part of #243
Only user-facing changes are that
Composite.nodes
got renamed toComposite.children
and is abidict
instead ofDotDict
.