pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
10 stars 1 forks source link

[minor] Refactor channel #251

Closed liamhuber closed 3 months ago

liamhuber commented 3 months ago

This re-parents Channel onto HasLabel (patch) and renames the Channel.node attribute to Channel.owner (minor). As we move to composition mixins (#243), this will help break apart where channels depend on their owner being something that "has IO" and where they really depend on it being a node (basically only necessary for node injection on OutputData).

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 3 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/refactorchannel

codacy-production[bot] commented 3 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.42% (target: -1.00%) :white_check_mark: 94.59%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (9d7b286298f0eeaea77e34f3a86ad42aa004db8d) | 3151 | 2734 | 86.77% | | | Head commit (d0620f0c7915a1f70a76a195dfc8cf177c31f589) | 3254 (+103) | 2837 (+103) | 87.19% (**+0.42%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#251) | 351 | 332 | **94.59%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

codacy-production[bot] commented 3 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.42% (target: -1.00%) :white_check_mark: 94.59%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (9d7b286298f0eeaea77e34f3a86ad42aa004db8d) | 3151 | 2734 | 86.77% | | | Head commit (d0620f0c7915a1f70a76a195dfc8cf177c31f589) | 3254 (+103) | 2837 (+103) | 87.19% (**+0.42%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#251) | 351 | 332 | **94.59%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation