Closed liamhuber closed 7 months ago
Coverage variation | Diff coverage |
---|---|
:white_check_mark: +0.10% (target: -1.00%) | :white_check_mark: 97.62% |
You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Pulls
SingleValue
functionality out and let all nodes inherit from it as a new mixin. This allows us to use all the node injections on macros and workflows (as long as they only have one output channel), and means you don't need any special class to make a funciton "single value" -- as long as it's only got a single return value it will act this way be default. (That means we can even get rid of theSingleValue
class, but that is a separate PR).This change ran into an edge case where function nodes use
self
to store data. I solved this by adding new dict field to store it in -- since the field is pre-existing, we bypasses the getattr node injection. I actually like this, as adding state to function nodes was something to discourage to start with!TODO:
Contributes to #243
Closes #155
Non-goals:
SingleValue
from the codebase