Closed liamhuber closed 7 months ago
Coverage variation | Diff coverage |
---|---|
:white_check_mark: +0.05% (target: -1.00%) | :white_check_mark: 98.46% |
You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation
Windows unit tests failed with
graphviz.backend.execute.CalledProcessError: Command '[WindowsPath('dot'), '-Kdot', '-Tpdf', '-O', 'start_graph']' returned non-zero exit status 1. [stderr: b'Warning: Could not load "C:\\Miniconda3\\envs\\my-env\\Library\\bin\\gvplugin_pango.dll" - It was found, so perhaps one of its dependents was not. Try ldd.\r\nWarning: Could not load "C:\\Miniconda3\\envs\\my-env\\Library\\bin\\gvplugin_pango.dll" - It was found, so perhaps one of its dependents was not. Try ldd.\r\nFormat: "pdf" not recognized. Use one of: bmp canon cmap cmapx cmapx_np dot dot_json emf emfplus eps fig gd gd2 gif gv imap imap_np ismap jpe jpeg jpg json json0 metafile mp pdf pic plain plain-ext png pov ps ps2 svg tif tiff tk webp xdot xdot1.2 xdot1.4 xdot_json\r\n']
Doesn't look directly related to these changes, but I might need to go back and pin graphviz to some other version.
Yyyep.
======================================================================
ERROR: test_draw (test_node.TestNode.test_draw)
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\Miniconda3\envs\my-env\Lib\site-packages\graphviz\backend\execute.py", line 88, in run_check
proc.check_returncode()
File "C:\Miniconda3\envs\my-env\Lib\subprocess.py", line 502, in check_returncode
raise CalledProcessError(self.returncode, self.args, self.stdout,
subprocess.CalledProcessError: Command '[WindowsPath('dot'), '-Kdot', '-Tpdf', '-O', 'start_graph']' returned non-zero exit status 1.
Windows error needs to be fixed, but it's from graphviz and unrelated to these changes.
This will be useful for building nodes that take other node classes as input and want to build their own corresponding IO based on that class's IO without having to instantiate it first. It also borders on necessary for the long-term goal of being able to suggest nodes to users based on ontological (or regular...) type hints ala
ironflow
.Example:
Tasks:
Non-goals:
Macro
, which makes sense but is left to another PRWorkflow
, which doesn't make sense since its IO is dynamic anyhowMinor bump as the signature for
AbstractFunction
has changed.