Closed liamhuber closed 7 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Coverage variation | Diff coverage |
---|---|
:white_check_mark: -0.05% (target: -1.00%) | :white_check_mark: 100.00% |
You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation
======================================================================
FAIL: test_draw (test_node.TestNode.test_draw) [Testing with format pdf]
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\a\pyiron_workflow\pyiron_workflow\tests\unit\test_node.py", line 326, in test_draw
with self.assertRaises(
AssertionError: CalledProcessError not raised : Graphviz doesn't seem to be happy about the combindation PDF format and Windows right now. We throw a warning for it in `Node.draw`, so if this test ever fails and this combination _doesn't_ fail, remove this extra bit of testing and remove the warning.
Looks like upstream might have patched windows already...
Minimal changes to remove
output_labels
from the signature ofAbstractMacro
and make these a class property (_provided_output_labels
), just like inAbstractFunction
.Non-goals:
AbstractMacro
andAbstractFunction
out into a mixin