pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
10 stars 1 forks source link

[minor] Make macro output labels a class attribute #269

Closed liamhuber closed 2 months ago

liamhuber commented 3 months ago

Minimal changes to remove output_labels from the signature of AbstractMacro and make these a class property (_provided_output_labels), just like in AbstractFunction.

Non-goals:

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 3 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/macro_output_labels_toclassattr

codacy-production[bot] commented 3 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: -0.05% (target: -1.00%) :white_check_mark: 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (98d457080dc53ef38554b73e6f95c5303eeab3b0) | 3418 | 2999 | 87.74% | | | Head commit (14064ea6f0729b9966cd5a7a45977d5ef788929b) | 3420 (+2) | 2999 (+0) | 87.69% (**-0.05%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#269) | 11 | 11 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

liamhuber commented 3 months ago
 ======================================================================
FAIL: test_draw (test_node.TestNode.test_draw) [Testing with format pdf]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\pyiron_workflow\pyiron_workflow\tests\unit\test_node.py", line 326, in test_draw
    with self.assertRaises(
AssertionError: CalledProcessError not raised : Graphviz doesn't seem to be happy about the combindation PDF format and Windows right now. We throw a warning for it in `Node.draw`, so if this test ever fails and this combination _doesn't_ fail, remove this extra bit of testing and remove the warning.

Looks like upstream might have patched windows already...