Closed liamhuber closed 2 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Coverage variation | Diff coverage |
---|---|
:white_check_mark: -0.02% (target: -1.00%) | :white_check_mark: 72.07% |
You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation
Per @pmrv's comment, the
Function
andMacro
classes that overrode__new__
to return children ofAbstractFunction
andAbstractMacro
we an unnecessary complication -- we can do the same thing with a plain old function. Here we transform those creators back into functions, and then give the base classes back their original names ofFunction
andMacro
.@pmrv the main thing I want review on is to see if you have any better ideas for naming. Right now (class, decorator -> class, creator -> instance) are (
Function
,as_function_node
,function_node
) and (Macro
,as_macro_node
,macro_node
). I also re-namedCreator.wrap_as
toCreator.wrap
; so before/after goes likeWorkflow.create.Function
/Workflow.create.function_node
,Workflow.wrap_as.function_node
/Workflow.wrap.as_function_node
, etc..