[minor] Extract a parent class for pulling IO data from a class method

liamhuber commented 2 months ago

A refactor to eliminate the code redundancy from shared behaviour for scraping IO channel info from Function.node_function and Macro.graph_creator.

Still TODO:

[x] Refactor out the creator function and decorators into a parent to stop duplicating code
[x] Move the preview stuff to its own submodule
[x] Take the tests for this stuff in test_function and test_macro and move them into a new test file that specifically tests this mixin behaviour (a bit is probably left in the macro tests for the "self." lstripping)

github-actions[bot] commented 2 months ago

:point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/static_ioparent

codacy-production[bot] commented 2 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
:white_check_mark: +0.18% (target: -1.00%)	:white_check_mark: 96.53%

Coverage variation details

| | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (e20199f238475297544ca0623e8cbfa9612e1c81) | 3449 | 3015 | 87.42% | | | Head commit (d6ee64c5d89c9314d609eb68c7ed0aecaa08b472) | 3475 (+26) | 3044 (+29) | 87.60% (**+0.18%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `

Diff coverage details

| | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#282) | 173 | 167 | **96.53%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings Change summary preferences

_{You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation}

review-notebook-app[bot] commented 2 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

pyiron / pyiron_workflow