pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
10 stars 1 forks source link

[patch] Canonical macro self-variable #283

Closed liamhuber closed 2 months ago

liamhuber commented 2 months ago

Switches the self-like argument in macro-defining functions over to self, except for a few cases where we leave it as wf and explicitly tell the story about how you may be working with a worklfow and want to convert it to a macro by copying and pasting.

Also cleaned up some other non-breaking problems with the pedagogical text (english, some variable names, non-impactful code statements, etc.) and tidied up some unused imports.

review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 2 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/canonicalmacro

codacy-production[bot] commented 2 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.00% (target: -1.00%) :white_check_mark:
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (d6ee64c5d89c9314d609eb68c7ed0aecaa08b472) | 3475 | 3044 | 87.60% | | | Head commit (7b2965267dd7c7efd39fb754f0b9612f8eea7e6c) | 3474 (-1) | 3043 (-1) | 87.59% (**+0.00%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#283) | 0 | 0 | **∅ (not applicable)** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation