pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
10 stars 1 forks source link

[patch] Refactor static node #289

Closed liamhuber closed 2 months ago

liamhuber commented 2 months ago

StaticNode guarantees that the node's IO specification is available at the class level; here we pull up the IO construction in Function to this parent class level, and leverage it also in Macro (currently the only other child in the DecoratedNode(StaticNode) inheritance tree). The somewhat complex node creation in Macro is then simplified to creating value links between the child graph and the macro's IO (already created by the StaticNode portion of the super().__init__ call). As a side effect I got to remove a handful of methods on related classes. This is all purely under-the hood streamlining and required no test modification or UI changes.

github-actions[bot] commented 2 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/refactor_staticnode

codacy-production[bot] commented 2 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: -0.04% (target: -1.00%) :white_check_mark: 95.65%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (720bb576834b35cdecb80136a52cd4de86894925) | 3525 | 3092 | 87.72% | | | Head commit (1ac11970d6b2f69f753cf806942a9d3f2f6f3bc8) | 3506 (-19) | 3074 (-18) | 87.68% (**-0.04%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#289) | 23 | 22 | **95.65%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation