pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
10 stars 1 forks source link

Update pyiron-verse dependencies #302

Closed liamhuber closed 2 months ago

liamhuber commented 2 months ago

Synchronized to avoid headaches with patch number upper limits, so we can get it all done in a single pull

github-actions[bot] commented 2 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/dependencybumps

codacy-production[bot] commented 2 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.00% (target: -1.00%) :white_check_mark:
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (ef79cc72998c3e64d5866663caa38d31844d12c6) | 3501 | 3070 | 87.69% | | | Head commit (6b3930d4f5adc89d736d524aad269914f2fa4c1d) | 3501 (+0) | 3070 (+0) | 87.69% (**+0.00%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#302) | 0 | 0 | **∅ (not applicable)** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 8883395469

Details


Files with Coverage Reduction New Missed Lines %
channels.py 5 94.3%
executors/cloudpickleprocesspool.py 21 58.44%
<!-- Total: 26 -->
Totals Coverage Status
Change from base Build 8882190187: 0.0%
Covered Lines: 3070
Relevant Lines: 3501

💛 - Coveralls
liamhuber commented 2 months ago

Doctest on CloudpickleProcessPoolExecutor failed. Definitely running fine locally, so I will start by re-running in case it was a resource hiccup.

 ======================================================================
FAIL: CloudpickleProcessPoolExecutor (pyiron_workflow.executors.cloudpickleprocesspool)
Doctest: pyiron_workflow.executors.cloudpickleprocesspool.CloudpickleProcessPoolExecutor
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/share/miniconda3/envs/my-env/lib/python3.10/doctest.py", line 2221, in runTest
    raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for pyiron_workflow.executors.cloudpickleprocesspool.CloudpickleProcessPoolExecutor
  File "/home/runner/work/pyiron_workflow/pyiron_workflow/pyiron_workflow/executors/cloudpickleprocesspool.py", line 31, in CloudpickleProcessPoolExecutor

----------------------------------------------------------------------
File "/home/runner/work/pyiron_workflow/pyiron_workflow/pyiron_workflow/executors/cloudpickleprocesspool.py", line 112, in pyiron_workflow.executors.cloudpickleprocesspool.CloudpickleProcessPoolExecutor
Failed example:
    print(instance.result.result)
Exception raised:
    Traceback (most recent call last):
      File "/usr/share/miniconda3/envs/my-env/lib/python3.10/doctest.py", line 1350, in __run
        exec(compile(example.source, filename, "single",
      File "<doctest pyiron_workflow.executors.cloudpickleprocesspool.CloudpickleProcessPoolExecutor[13]>", line 1, in <module>
        print(instance.result.result)
    AttributeError: 'NoneType' object has no attribute 'result'

----------------------------------------------------------------------
Ran 180 tests in 7.157s

FAILED (failures=1, skipped=16)
Error: Process completed with exit code 1.
liamhuber commented 2 months ago

I got rid of the offending doctest snippet and all tests pass, so we're not hitting some sort of fundamental incompatibility with py3.10 and CloudpickleProcessPoolExecutor, there is just something weird going on with the exact scenario in the doctest.

liamhuber commented 2 months ago

Ok, adding 1s sleep did the trick. Not something I'm thrilled about, but not worth digging into when I can't even reproduce it locally.