pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
11 stars 1 forks source link

JNmpi lammps nodes patch version ~0.7.0~ 0.7.1 #315

Closed liamhuber closed 4 months ago

review-notebook-app[bot] commented 4 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 4 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/JNmpi_lammps_nodespatch070

codacy-production[bot] commented 4 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for b69ca0ba9961b0985ff1f65afb1afdf9074ebe4a[^1] :white_check_mark: 82.03%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (b69ca0ba9961b0985ff1f65afb1afdf9074ebe4a) | Report Missing | Report Missing | Report Missing | | | Head commit (1c9aa18bb3e86e13720b769960960e69e6a591f0) | 4842 | 3524 | 72.78% | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#315) | 1263 | 1036 | **82.03%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

liamhuber commented 4 months ago

@JNmpi, these are the minimal changes (at least that's my attempt...) to get your node packages synced with the main branch. Here my goal was only to get the notebooks running, and I didn't purge any extraneous tools or check all the nodes.

Now that the main branch has for-loop stuff (including an .iter method), the changes here are all inside node_library. My next step is to get a pyiron_nodes repo set up as discussed and migrate the non-standard nodes over there, including what is left in dev_tools for later cleanup/exploitation.