pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
10 stars 1 forks source link

[minor] Convert to pyproject.toml #329

Closed liamhuber closed 1 month ago

liamhuber commented 1 month ago

Including changes to identifiers and authorship, and new release CI, as well as a temporary CI script to test out the build. I'm omitting many build requirements as an experiment.

A minor bump insofaras the conda release will have different dependency limits

liamhuber commented 1 month ago

The crux of the issue is that I'm a massive idiot and I didn't add

from ._version import get_versions

__version__ = get_versions()["version"]

to pyiron_workflow.__init__.

This looks like it's working though and I'll come back and clean it up (including git history) soon.

codacy-production[bot] commented 1 month ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.01% (target: -1.00%) :white_check_mark: 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (95ab3f5efc21ab8bfbfea762901b926f2c9346d8) | 3946 | 3524 | 89.31% | | | Head commit (a802ad866d3bf5f438873e65789473ba2f726624) | 3948 (+2) | 3526 (+2) | 89.31% (**+0.01%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#329) | 2 | 2 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9090074920

Details


Totals Coverage Status
Change from base Build 9086063184: 0.005%
Covered Lines: 3526
Relevant Lines: 3948

💛 - Coveralls
liamhuber commented 1 month ago

I fought with this a lot, but ultimately the problem was extremely simple: I had forgotten to add from ._version import get_versions; __version__ = get_versions()["version"] to the module's init file. The struggle resulted in a few nice little QoL changes to pyiron/actions, but I wish I had found a quicker path. I reset to main and force-pushed over all my blundering to keep the history cleaner.