pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
10 stars 1 forks source link

[patch] Write a workflow that runs tests on the latest conda release #334

Closed liamhuber closed 1 month ago

github-actions[bot] commented 1 month ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/testconda

codacy-production[bot] commented 1 month ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.00% (target: -1.00%) :white_check_mark:
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (3c5b71aecbe39101dcab8df646d80660a4e7ea35) | 3948 | 3526 | 89.31% | | | Head commit (a63ed94a2882a4e13e734628ea6fbbdf1367dab5) | 3948 (+0) | 3526 (+0) | 89.31% (**+0.00%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#334) | 0 | 0 | **∅ (not applicable)** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9230154718

Details


Totals Coverage Status
Change from base Build 9115999265: 0.0%
Covered Lines: 3526
Relevant Lines: 3948

💛 - Coveralls
liamhuber commented 1 month ago

It looks like the file didn't write or something?

Run python $GITHUB_ACTION_PATH/../.support/condamerge.py ./environment.yml > ./environment.yml
Traceback (most recent call last):
  File "/home/runner/work/_actions/pyiron/actions/make_pip_optional/write-environment/../.support/condamerge.py", line 80, in <module>
    merge_env(
  File "/home/runner/work/_actions/pyiron/actions/make_pip_optional/write-environment/../.support/condamerge.py", line 65, in merge_env
    env_base['channels'],
TypeError: 'NoneType' object is not subscriptable

and

Run mamba env update -n my-env -f ./environment.yml

SpecNotFound: '/home/runner/work/pyiron_workflow/pyiron_workflow/environment.yml' is empty

Not sure if this is because of bad formatting of the env file, a mistake in pwd, or the env updater trying to read and write to the same place.

liamhuber commented 1 month ago
 ModuleNotFoundError: No module named 'test_macro'
E......Traceback (most recent call last):
  File "/home/runner/miniconda3/envs/my-env/lib/python3.12/site-packages/pympipool/backend/serial.py", line 65, in <module>
    main(argument_lst=sys.argv)
  File "/home/runner/miniconda3/envs/my-env/lib/python3.12/site-packages/pympipool/backend/serial.py", line 31, in main
    input_dict = interface_receive(socket=socket)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/miniconda3/envs/my-env/lib/python3.12/site-packages/pympipool/shared/communication.py", line 167, in interface_receive
    return cloudpickle.loads(socket.recv())
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'test_node'

Ok, this is just the pympipool error because I didn't put the tests in the python path.

liamhuber commented 1 month ago
 ======================================================================
ERROR: test_pull_and_executors (test_workflow.TestWorkflow.test_pull_and_executors)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/pyiron_workflow/pyiron_workflow/tests/unit/test_workflow.py", line 416, in test_pull_and_executors
    self.assertEquals(
    ^^^^^^^^^^^^^^^^^
AttributeError: 'TestWorkflow' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

----------------------------------------------------------------------

Right, python 3.12 totally deprecated my spelling mistake. It's patched now, but that PR is not in the latest release I'm testing here. Simplest to downgrade python for this test for now. It's actually the test itself failing and not the source code, so I don't feel too terrible about this. Good reminder to pay attention to deprecation warnings though.

liamhuber commented 1 month ago

Note: comment history on this page wont' make much sense anymore, because I force-pushed over all the development and debug commits.

codacy-production[bot] commented 1 month ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.00% (target: -1.00%) :white_check_mark:
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (3c5b71aecbe39101dcab8df646d80660a4e7ea35) | 3948 | 3526 | 89.31% | | | Head commit (7bab379bac308cb406aac7073b78000e82c45e66) | 3948 (+0) | 3526 (+0) | 89.31% (**+0.00%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#334) | 0 | 0 | **∅ (not applicable)** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

liamhuber commented 1 month ago

Super. Test failed, but in exactly the expected way for the last release -- with the assertEquals deprecation in py3.12. 👍👍