pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
14 stars 1 forks source link

[minor] Hash injection labels #367

Closed liamhuber closed 5 months ago

liamhuber commented 5 months ago

Working on a use case, the injection labels quickly got too long for the filesystem. For very short injection paths it was nice having the provenance of the injection listed right in the name, but it quickly gets silly. Anyhow, the provenance is still there in the graph connections. Now, instead, lean on hashes for the name. The class of the injection is still included, to give at least some quick idea what it's there for when looking at the label.

Also snuck in a hotfix for the last PR.

This is minor because it removes an (unused) public method, and because it may screw up loading old save files that had injected nodes. I don't expect either of these to present a practical problem.

github-actions[bot] commented 5 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/hash_injectionlabels

codacy-production[bot] commented 5 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.06% (target: -1.00%) :white_check_mark: 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (64ed0f57b246ab8d2b116c62a19233cda90662e5) | 3445 | 3185 | 92.45% | | | Head commit (a1c062b3a89786137f7c69725a7e5037ee1ea086) | 3444 (-1) | 3186 (+1) | 92.51% (**+0.06%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#367) | 3 | 3 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences


:rocket: Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9589193821

Details


Files with Coverage Reduction New Missed Lines %
mixin/injection.py 4 94.74%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 9589110125: 0.06%
Covered Lines: 3186
Relevant Lines: 3444

💛 - Coveralls