pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
11 stars 1 forks source link

[patch] Composite serialization bugs #369

Closed liamhuber closed 3 months ago

liamhuber commented 3 months ago

I ran into a few issues when I tried to put a macro as the body node in a for-loop, just a couple of bugs in the (de)serialization. The actual fixes are just a couple lines, and the rest is tests that fail when the bugfixes aren't there.

github-actions[bot] commented 3 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/composite_serializationbugs

codacy-production[bot] commented 3 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: -0.15% (target: -1.00%) :white_check_mark: 46.15%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (bdb292541d8924f72a2a0fc956bf191621185ccc) | 3444 | 3186 | 92.51% | | | Head commit (88f0bd6ed242ffcd96063421455fd1c9ee5da444) | 3456 (+12) | 3192 (+6) | 92.36% (**-0.15%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#369) | 13 | 6 | **46.15%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences


:rocket: Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9636498860

Details


Files with Coverage Reduction New Missed Lines %
nodes/for_loop.py 3 98.03%
nodes/composite.py 7 91.13%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 9614702153: -0.1%
Covered Lines: 3192
Relevant Lines: 3456

💛 - Coveralls