[patch] :fire: :bug: make sure for-loops re-set their value links like macros

liamhuber commented 5 days ago

Honestly, I basically just forgot that for-loops are not actually macros. Ideally, this behaviour would come from a shared parent class, like StaticComposite analogous to StaticNode. Unfortunately, that gives circular imports because the creator object is on Composite. Once Workflow and Macro do not share access to the creator, such an abstraction will be possible. In the meantime, I just tolerate the once-duplicated code.

github-actions[bot] commented 5 days ago

:point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/fix_fornode

codacy-production[bot] commented 5 days ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
:white_check_mark: +0.04% (target: -1.00%)	:white_check_mark: 100.00%

Coverage variation details

| | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (3a3b3ee15c0c516db8a588ce9c042313fae7c461) | 3456 | 3192 | 92.36% | | | Head commit (4abceed884969358e15a9152a979d6262894a0a9) | 3472 (+16) | 3208 (+16) | 92.40% (**+0.04%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `

Diff coverage details

| | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#373) | 16 | 16 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings Change summary preferences

_{:rocket: Don’t miss a bit, follow what’s new on Codacy.}

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9669950558

Details

0 of 0 changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.04%) to 92.396%

Files with Coverage Reduction	New Missed Lines	%
nodes/for_loop.py	3	98.21%
<!--	Total:	3		-->

Totals
Change from base Build 9669839231:	0.04%
Covered Lines:	3208
Relevant Lines:	3472

pyiron / pyiron_workflow