pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
14 stars 1 forks source link

[minor] Executorlib ci and docs #388

Closed liamhuber closed 3 months ago

liamhuber commented 4 months ago

A follow-up to #386 that purges references to pympipool in the docs and executor class name.

I also switch to macos-latest as executorlib uses for its CI.

This removes PyMpiPoolExecutor as a Creator attribute, changing the API, so not a patch; minor.

EDIT: After merging in the stack, this also removes the default Creator.Executor, so we now always specifically ask for ProcessPoolExecutor or executorlib.Executor accordingly.

review-notebook-app[bot] commented 4 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 4 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/executorlibci

codacy-production[bot] commented 4 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.00% (target: -1.00%) :white_check_mark: 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (aef1efc58f3d7a666b488be08d369aebe5a078f2) | 3472 | 3208 | 92.40% | | | Head commit (9183e484b8feee149b6697b16b8d246330dbe82f) | 3470 (-2) | 3206 (-2) | 92.39% (**+0.00%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#388) | 2 | 2 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences


:rocket: Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

liamhuber commented 4 months ago

OSX tests started quickly, but timed out to failure

liamhuber commented 4 months ago

The tests run fine locally, so to start I'll just try rerunning

liamhuber commented 4 months ago

Nope, still hanging. Unfortunately from the standard log it's not clear what test is doing it, and I can't reproduce it locally. @jan-janssen, thoughts?

liamhuber commented 4 months ago

Hanging is just CI related and not a true failure