pyiron / pyiron_workflow

Graph-and-node based workflows
BSD 3-Clause "New" or "Revised" License
15 stars 1 forks source link

[patch] Simplify loop signature #445

Closed liamhuber closed 2 months ago

liamhuber commented 2 months ago

Patches a bug when instantiating multiple for nodes with variations in the output format, and simplifies the for-node signature.

Before:

from pyiron_workflow import Workflow

n = Workflow.create.for_node(
    body_node_class=Workflow.create.standard.Add,
    iter_on=("other",),
    obj=1,
    other=[1, 2]
)

Now:

from pyiron_workflow import Workflow

n = Workflow.create.for_node(
    body_node_class=Workflow.create.standard.Add,
    iter_on="other",
    obj=1,
    other=[1, 2]
)
review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 2 months ago

Binder :point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/simplify_loopsignature

codacy-production[bot] commented 2 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.01% (target: -1.00%) :white_check_mark: 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (8c50aeb4a1fe093cc26cfb25fa9c84c86da042f5) | 3192 | 2917 | 91.38% | | | Head commit (c2fb19ceff00357274b73975bed0cacaf75373d8) | 3195 (+3) | 2920 (+3) | 91.39% (**+0.01%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#445) | 5 | 5 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10754131720

Details


Totals Coverage Status
Change from base Build 10753852897: 0.008%
Covered Lines: 2920
Relevant Lines: 3195

💛 - Coveralls