[patch] `Runnable` flexibility and a new output signal

liamhuber commented 2 months ago

Now we always use the same callback function, but each step of the Runnable.run cycle flexibly lets child classes define kwargs for each step. This lets us stop passing the callback function as an argument and just always use Runnable._finish_run.

In Node, the new kwargs mean we can move firing the signals over to the _run_finally method, and take advantage of this to add a new failed output signal.

There's a decent amount going on under the hood here, but for users there is no incompatible changes, just the new signal.

github-actions[bot] commented 2 months ago

:point_left: Launch a binder notebook on branch _pyiron/pyiron_workflow/singlefinish

codacy-production[bot] commented 2 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
:white_check_mark: -0.01% (target: -1.00%)	:white_check_mark: 94.59%

Coverage variation details

| | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (f95280769a35ad40861d79d1fc4e0917f116151b) | 3270 | 2984 | 91.25% | | | Head commit (86385bc0051ee66cdeb0ce6028cdab88de35e1b2) | 3279 (+9) | 2992 (+8) | 91.25% (**-0.01%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `

Diff coverage details

| | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#467) | 37 | 35 | **94.59%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`