Closed jan-janssen closed 3 weeks ago
The recent updates in the pympipool
library involve adjustments across multiple files to improve the management of worker threads in parallel computing environments. The primary change introduces the max_workers
parameter and recommends using max_cores
for better alignment with standard thread management practices.
File Path | Change Summary |
---|---|
pympipool/__init__.py |
Added max_workers parameter to Executor class, suggesting the use of max_cores . |
pympipool/scheduler/__init__.py |
Introduced validate_number_of_cores function and updated create_executor to utilize max_workers . |
pympipool/shared/inputcheck.py |
Added validate_number_of_cores function definition. |
max_cores
to max_workers
to align with the standard library. The recent changes in the PR, which reintroduce max_workers
, might address this concern by ensuring consistency with Python's ProcessPoolExecutor
and ThreadPoolExecutor
.🐰✨ A tiny hop in code, a giant leap for functionality, From cores to workers, we redefine the flow, Threads align, and systems glow, In the burrow of bytes, we watch it grow! 🌟🚀🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
max_workers
to theExecutor
class, enabling users to define the number of cores for parallel processing.max_cores
overmax_workers
for optimal resource utilization.Executor
class, ensuring the accuracy and effectiveness of parallel execution functionality.