pyj4104 / sipdroid

Automatically exported from code.google.com/p/sipdroid
GNU General Public License v3.0
0 stars 0 forks source link

Enhancement request - Call Recording #390

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. start SipDroid
2. place/receive a call
3. all perfect

What is the expected output? What do you see instead?
an option to record the calls.
I know that in some countries it's illegal, but not in all countries.

What version of the product are you using? On what device/operating system?
andriod 1.6
cianogen mod 4.2.15.1

Which SIP server are you using? What happens with PBXes?
072.012.net, orange Israel, PBXes

Which type of network are you using?
WiFi, 3G

Please provide any additional information below.
please make this MUST HAVE option available

Original issue reported on code.google.com by Spon4ik on 29 Mar 2010 at 7:15

GoogleCodeExporter commented 8 years ago

Original comment by pmerl...@googlemail.com on 29 Mar 2010 at 7:59

GoogleCodeExporter commented 8 years ago
Yes, I would like to have this too.

Original comment by beat.lu...@gmail.com on 15 Apr 2010 at 11:52

GoogleCodeExporter commented 8 years ago
I doubt this will be added - sipdroid seems to be associated with pbxes.org and 
they offer call recording is a paid option. However, it is open source, so I 
might add this at some point.

Original comment by tdh...@gmail.com on 12 Jul 2010 at 1:37

GoogleCodeExporter commented 8 years ago
I'll wait

Original comment by Spon4ik on 12 Jul 2010 at 2:10

GoogleCodeExporter commented 8 years ago
I took a look at the code. It seems like it will be reasonably simple to do. 
Here's what my 'final version' will hopefully look like:

1. An extra preference toggle: 'Record all calls'
2. If set, all calls will be recorded to /sdcard/Ripdroid/<time and date>.mp3
3. Incoming/outgoing will be in the left and right channels of the mp3.

So far I have it successfully recording the incoming part to a raw audio file. 
I've attached an example.

Original comment by tdh...@gmail.com on 13 Jul 2010 at 10:34

Attachments:

GoogleCodeExporter commented 8 years ago
Ok, I got it to work. Currently it does this:

1. Record incoming audio for each call to /sdcard/<time and date>_in.wav
2. Record outgoing audio for each call to /sdcard/<time and date>_out.wav

Caveats:

1. Poor error handling. If it can't write to the file nothing happens. It also 
blindly overwrites the file if it already exists (unlikely, unless you make two 
calls within a second).
2. Wav not MP3 so expect large files (it will be a constant 0.92 MB/minute).
3. Audio may get out of sync if there is packet loss or you are on hold or 
other stuff.
4. Assumes 8 kHz sampling rate. If this changes, you'll still get the audio but 
it will be chipmunk-esque.
5. I still need to change the package name before I release it.

Original comment by tdh...@gmail.com on 13 Jul 2010 at 12:15

GoogleCodeExporter commented 8 years ago
@tdhutt: I think you don't have to fork it to have this implemented. Just try 
to do a diff between trunk and our call recording modified version and post it. 
I'm sure it will be merged in.

Original comment by marcu...@gmail.com on 13 Jul 2010 at 2:21

GoogleCodeExporter commented 8 years ago
Yes, sure!

Original comment by pmerl...@googlemail.com on 13 Jul 2010 at 8:01

GoogleCodeExporter commented 8 years ago
Ah cool, I will clean up the code as much as possible and add more preferences 
to control things. :-)

Original comment by tdh...@gmail.com on 13 Jul 2010 at 8:07

GoogleCodeExporter commented 8 years ago
Patch attached.

Notes:

1. Both halves of calls are now recorded to the same wav, but it is done in a 
seek()-heavy way. Not sure if that is very efficient.
2. I added some preferences, but I didn't know a good way to connect them to 
the code (which is in org.sipdroid.media) so they don't do anything yet.
3. Calls are saved to /sdcard/Sipdroid_Recordings/
4. Max call length: 18 hours. :-)
5. Some non-changes crept into the diff, e.g. I have to edit the Application.mk 
to get it to build for some reason.
6. No error message reporting. Sorry I don't know your code well enough!
7. Packet loss will probably cause the incoming/outgoing audio to go out of 
sync.

Original comment by tdh...@gmail.com on 14 Jul 2010 at 8:53

Attachments:

GoogleCodeExporter commented 8 years ago
Pre-built APK here:

http://concentriclivers.com/?p=Sipdroid

NB, as before the settings aren't connected to anything. This is based on SVN 
from a week ago.

Original comment by tdh...@gmail.com on 14 Jul 2010 at 9:38

GoogleCodeExporter commented 8 years ago

Original comment by pmerl...@googlemail.com on 18 Jul 2010 at 10:59

GoogleCodeExporter commented 8 years ago
Using tdhutt's apk right now, hope this feature is implemented in the official 
version soon.

Original comment by JeSuis...@gmail.com on 5 Sep 2010 at 12:12

GoogleCodeExporter commented 8 years ago

Original comment by pmerl...@googlemail.com on 6 Sep 2010 at 12:14

GoogleCodeExporter commented 8 years ago
tdhutt, I've added you as a project member. Thanks for checking your patch in!

Original comment by pmerl...@googlemail.com on 17 Sep 2010 at 8:47

GoogleCodeExporter commented 8 years ago
heya,

Any word for when this might be included in a future release of Sipdroid? =)

Cheers,
Victor

Original comment by victorh...@gmail.com on 15 Dec 2010 at 3:30

GoogleCodeExporter commented 8 years ago

Original comment by pmerl...@googlemail.com on 31 Mar 2011 at 4:25

GoogleCodeExporter commented 8 years ago
Awesome, seems to be working. Thank you!

Original comment by simonbro...@gmail.com on 31 Mar 2011 at 5:20

GoogleCodeExporter commented 8 years ago
I'm using MX Skype Recorder and you may also want to try it
http://skyperec.com 
as it shows itself as a stable and reliable app what is crucial for important 
business conversations.
I recommend!

Original comment by solution...@gmail.com on 2 Jul 2012 at 3:15