search

pyjanitor-devs / pandas_flavor

The easy way to write your own flavor of Pandas
https://zsailer.github.io/software/pandas-flavor/
MIT License
301 stars 17 forks source link

Support extending xarray #13

Closed eyaltrabelsi closed 5 years ago

eyaltrabelsi commented 5 years ago

I think it can be beneficial to allow to extend xarray (for example of usecase )

Zsailer commented 5 years ago

Hm, this is a really cool idea.

I'd be happy to review+accept a PR for this idea. Would you be interested in porting this from pyjanitor?

Zsailer commented 5 years ago

@ericmjl @zbarry pinging you for discussion as well.

Now I'm regretting the name pandas_flavor 😆

eyaltra commented 5 years ago

@Zsailer sure how should i name the file :)

Zsailer commented 5 years ago

For now, let's name it xarray.py and import the register methods in the __init__.py. We may refactor after further discussion.

zbarry commented 5 years ago

Yeah this would be great to have in here. It felt weird basically cloning pf's model in a separate package.

Now I'm regretting the name pandas_flavor laughing

:)

zbarry commented 5 years ago

@Zsailer - if it's ok with you, would you mind cutting a release with the xarray addition and update the conda-forge package so I could go ahead and refactor the pyjanitor xarray code to depend on it?

Zsailer commented 5 years ago

@zbarry, I've released v0.2.0 with xarray support. It's available on PyPI now. I'm updating the conda-forge package—you can watch the progress here.

zbarry commented 5 years ago

@Zsailer - Appreciate it!

Zsailer commented 5 years ago

Closing, since this was merged in #15! Thanks, @eyaltrabelsi!

zbarry commented 5 years ago

Thanks again, both.

SethMMorton commented 4 years ago

It seems that pandas_flavor now requires xarray to be installed now, even if I choose not to use xarray. Perhaps this should have been an optional dependency?