Open Zeroto521 opened 2 years ago
@Zeroto521 impute covers this usecase; at this point, I wonder if it is okay to deprecate one of these functions, so we have just one that covers na filling? @pyjanitor-devs/core-devs
@samukweku I'm okay with deprecating one of impute
or fill_empty
. Seems like impute
not only covers the "mean/mode/.." use case, but also the imputing with constant value, which is fill_empty
's current functionality?
I'll be inclined to keep impute
over fill_empty
(at least within the DS/ML community, impute is a commonly-used term; not sure about the broader data world.)
yea, impute is a wrapper around fillna, with the benefits of the statistics imputation.
Brief Description
As title. For some data, such as GDP, filling its NaN value with 0 isn't a good idea. Because most of the GDP values end in million. We don't fill NaN value with
0
rather mean value.API
value
andmethod
shouldn't beNone
.method
should be 'mean', 'median', or 'mode'.Example