pyjanitor-devs / pyjanitor

Clean APIs for data cleaning. Python implementation of R package Janitor
https://pyjanitor-devs.github.io/pyjanitor
MIT License
1.37k stars 171 forks source link

[BUGFIX]`coalesce` #1325

Closed samukweku closed 10 months ago

samukweku commented 10 months ago

PR Description

Please describe the changes proposed in the pull request:

This PR improves coalesce.

PR Checklist

Please ensure that you have done the following:

  1. [x] PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  2. [x] If you're not on the contributors list, add yourself to AUTHORS.md.
  3. [ ] Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

Relevant Reviewers

Please tag maintainers to review.

ericmjl commented 10 months ago

🚀 Deployed on https://deploy-preview-1325--pyjanitor.netlify.app

codecov[bot] commented 10 months ago

Codecov Report

Merging #1325 (378a047) into dev (88b48b9) will increase coverage by 0.39%. Report is 1 commits behind head on dev. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1325 +/- ## ========================================== + Coverage 94.50% 94.90% +0.39% ========================================== Files 80 80 Lines 4330 4336 +6 ========================================== + Hits 4092 4115 +23 + Misses 238 221 -17 ```
samukweku commented 10 months ago

@pyjanitor-devs/core-devs @ericmjl how do I check the minimum pandas version? in the tests, i can see pandas 1.3.5, whereas working in dev i see the minimum version is pandas 1.5.3

ericmjl commented 10 months ago

@pyjanitor-devs/core-devs @ericmjl how do I check the minimum pandas version? in the tests, i can see pandas 1.3.5, whereas working in dev i see the minimum version is pandas 1.5.3

This is interesting, I need to check how the environments are built. Give me one moment, @samukweku!

ericmjl commented 10 months ago

@samukweku environment-dev.yml was pinned to 1.3.5. I'm not sure what the reason is, but we should release the pin and let it float with the ecosystem. I'm going to make a push.

ericmjl commented 10 months ago

@samukweku I'm not sure what's happening after releasing the version pin, but pivot_wider's docstring examples appear to be failing. I made sure pytest skipped those tests, since we are going to be deprecating that function anyways.

ericmjl commented 10 months ago

Since I pushed to the PR, that means I've accepted the contents of it :smile:. Officially approving, and now going to merge! Thank you, @samukweku!