Closed samukweku closed 10 months ago
🚀 Deployed on https://deploy-preview-1325--pyjanitor.netlify.app
Merging #1325 (378a047) into dev (88b48b9) will increase coverage by
0.39%
. Report is 1 commits behind head on dev. The diff coverage is100.00%
.
@pyjanitor-devs/core-devs @ericmjl how do I check the minimum pandas version? in the tests, i can see pandas 1.3.5, whereas working in dev i see the minimum version is pandas 1.5.3
@pyjanitor-devs/core-devs @ericmjl how do I check the minimum pandas version? in the tests, i can see pandas 1.3.5, whereas working in dev i see the minimum version is pandas 1.5.3
This is interesting, I need to check how the environments are built. Give me one moment, @samukweku!
@samukweku environment-dev.yml
was pinned to 1.3.5. I'm not sure what the reason is, but we should release the pin and let it float with the ecosystem. I'm going to make a push.
@samukweku I'm not sure what's happening after releasing the version pin, but pivot_wider
's docstring examples appear to be failing. I made sure pytest skipped those tests, since we are going to be deprecating that function anyways.
Since I pushed to the PR, that means I've accepted the contents of it :smile:. Officially approving, and now going to merge! Thank you, @samukweku!
PR Description
Please describe the changes proposed in the pull request:
get_index_labels
is called early in the code - column check, easy column selection ...This PR improves coalesce.
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.md
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.