Closed samukweku closed 5 months ago
🚀 Deployed on https://deploy-preview-1341--pyjanitor.netlify.app
Attention: Patch coverage is 96.44269%
with 9 lines
in your changes are missing coverage. Please review.
Project coverage is 95.87%. Comparing base (
62c57c6
) to head (d7aafb9
). Report is 10 commits behind head on dev.:exclamation: Current head d7aafb9 differs from pull request most recent head 4fca4c0
Please upload reports for the commit 4fca4c0 to get more accurate results.
@samukweku is this one ready for review? On GitHub it looks like it's still being marked as a draft.
@ericmjl not yet, still got some optimisations that I am hopeful to pull off
@ericmjl not familiar with the jitter function. can i get your help with the failing test function. thanks
@ericmjl not familiar with the jitter function. can i get your help with the failing test function. thanks
Not a problem, @samukweku. I encountered a similar issue when testing locally so I decided to make the test a bit more lenient.
@samukweku, apologies for the long turnaround time here. I think we should merge this in, as (a) the PR has been open for a long time, and (b) I've already committed to the branch. Once the CI checks are done, I'll do a merge!
@samukweku I have merged! Thank you for taking care of pyjanitor, I really appreciate it!
PR Description
Please describe the changes proposed in the pull request:
This PR improves conditional_join.
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.md
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.