Closed samukweku closed 2 months ago
🚀 Deployed on https://deploy-preview-1397--pyjanitor.netlify.app
Attention: Patch coverage is 82.78689%
with 21 lines
in your changes missing coverage. Please review.
Project coverage is 89.23%. Comparing base (
6e77fbc
) to head (ef4f9f3
). Report is 11 commits behind head on dev.
I also noticed that the project test coverage has significantly gone down to <90%. I might need to dig further, but this is definitely a sign that we may need to invest more in covering edge cases throughout the repo.
This is the second part of a series of PRs that ultimately adds support for aggregations within
conditional_join
. where possible,ragged_arrays
can be returned to the user, either as slices or arrays of indices, which can be used inakimbo
, orawkward
orpyarrow
to aggregate the data. this should be faster than materializing the entire dataframe within pandas before aggregating.PR Description
Please describe the changes proposed in the pull request:
get_join_indices
functionThis PR relates to #1269 and #1396 .
Please tag maintainers to review.