pyjanitor-devs / pyjanitor

Clean APIs for data cleaning. Python implementation of R package Janitor

https://pyjanitor-devs.github.io/pyjanitor

MIT License

1.37k stars 170 forks source link

Samukweku/pivot longer simple #1400

Closed samukweku closed 2 months ago

samukweku commented 2 months ago

PR Description

Please describe the changes proposed in the pull request:

all forms of pivot_longer handled by two major functions reshape_by_spec and reshape_by_spec_others
at its core, any pivot_longer function has to create a spec and pass to one of the two functions above.
add lots of comments on the implementation logic (for future me or others)
deprecate dropna - no perf difference if user does it, and is not needed within pivot_longer, plus we avoid the complexity of determing which NA rows to drop

This PR improves pivot_longer.

Please tag maintainers to review.

@ericmjl

ericmjl commented 2 months ago

🚀 Deployed on https://deploy-preview-1400--pyjanitor.netlify.app