search

pyjanitor-devs / pyjanitor

Clean APIs for data cleaning. Python implementation of R package Janitor
https://pyjanitor-devs.github.io/pyjanitor
MIT License
1.37k stars 170 forks source link

[DOC] Un-deprecate join_apply (#1399) #1401

Closed lbeltrame closed 2 months ago

lbeltrame commented 2 months ago

PR Description

There is no current alternative to row-wise operations, so revert the deprecation for now as discussed in issue #1399.

This PR resolves #1399 .

PR Checklist

Please ensure that you have done the following:

  1. [x] PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  2. [x] If you're not on the contributors list, add yourself to AUTHORS.md.
  3. [x] Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.

Relevant Reviewers

Please tag maintainers to review.

samukweku commented 2 months ago

@lbeltrame looks good. Just needs one more review and we will merge if all goes well.

ericmjl commented 2 months ago

@lbeltrame thank you for the contribution! @samukweku would you be kind enough to cut a new release please?

samukweku commented 2 months ago

@ericmjl ok to make it as a patch? or minor?