Closed rrmdn closed 7 years ago
@pyk please add some labels for this
cc @adrianha @y68 @CodeRiderz
Not sure about this one, buddy.
When you open /candidates
page and you click one of the candidate, it should bring you to <DefaultResult />
instead of creating new page result called <OpenKandidat />
.
The <ResultGateway>
intended to be a wrapper to separate views between special keywords (pairings, medias, candidates ) and specific keyword like anies
, ahok
, ahok djarot
, kompas
or even an url
for news. It's there, because we would have a different looks / UI for those special pages and the default one.
We should create another smart container in <DefaultResult />
to manage whether a keyword is candidate, media, or news.
For example, if user type ahok
in the search field, it will bring you to /search/ahok
.
Then, this smart container inside <DefaultResult />
should give you a View
for a candidate
.
It's the same for Link
(s) listed in /candidates
page, it should bring you to /search/ahok
once you click it.
This way, we don't need to create another view / wrapper when user type agus
in the search field.
What do you think ?
any update?
@CodeRiderz
The
<ResultGateway>
intended to be a wrapper to separate views between special keywords (pairings, medias, candidates )
Unfortunately, this /candidate/:id
thingy is now another search term with special keywords:
(its now on stag: https://rojak-web.surge.sh)
Okay, I will accept this for now. Lets see if this will works with another features.
LGTM
Cool thanks
@rromadhoni ini udah aku bild juga di https://rojak.id ya 🙇
Summary
This PR is intended to add search-candidate functionality to rojak-ui-web.