pyk595 / pe

0 stars 0 forks source link

Contacted dates can be added before date of birth #5

Open pyk595 opened 2 years ago

pyk595 commented 2 years ago

image.png I can add a contacted date that is before the current birthdate. Might be a duplicate issue as mentioned previously for birth dates, but depending on implementation might not be a duplicate.

nus-se-script commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Birthdays can be edited to after last contacted date

image.png

I added a new contact, and changed the date of birth to after the last contacted date. This should not be allowed as you can't physically meet a contact before the date of birth


[original: nus-cs2103-AY2122S2/pe-interim#2940] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Unrealistic situation that users won't face, and if they do edit the birthday to after last contacted date, it would be an intentional behaviour that has special meaning for the user

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Solving the problem for date of birth (making it such that users cannot edit birth dates to after contacted dates) will not solve the issue for contacted dates (users can still edit/ add contacted dates to before birth date). At least 2 checks in both objects are needed.


:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Users might accidentally make a typo with the contacted dates, and assume that their dates are entered and saved correctly since it is a past date. It is the responsibility of the software to detect such issues and highlight them to the user.


:question: Issue severity

Team chose [severity.Medium] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]