search

pyke369 / PKMultipartInputStream

an NSInputStream subclass suitable for building multipart/form-data http requests bodies in MacOSX/iOS applications.
http://github.com/pyke369/PKMultipartInputStream
MIT License
73 stars 19 forks source link

PKMultipartElement [super init] #17

Closed jznadams closed 6 years ago

jznadams commented 7 years ago

I noticed that the following initializers of PKMultipartElement do not call [super init], while the others do:

- (id)initWithName:(NSString *)name filename:(NSString *)filename boundary:(NSString *)boundary path:(NSString *)path contentType:(NSString *)contentType
- (id)initWithName:(NSString *)name filename:(NSString *)filename boundary:(NSString *)boundary stream:(NSInputStream *)stream streamLength:(NSUInteger)streamLength

Is that intentional, or is that an oversight? I can create a PR if it needs to be added.

PS, thanks for this library!

VilemKurz commented 6 years ago

I think, it is an oversight. I am not a maintainer of this lib, but please, make a pull request. Hopefully it will be merged.

pyke369 commented 6 years ago

Done in PR #20.