pyladies / pyladies-elections-website

Code for http://elections.pyladies.com
http://elections.pyladies.com
MIT License
6 stars 7 forks source link

Adding the pt image of the global council structure #38

Closed deboraazevedo closed 4 years ago

deboraazevedo commented 4 years ago

PyLadies Pull Request

Please document the following. We will aim to be as timely as possible in processing your pull request, however as this is a volunteer staffed project anticipate at least a week for pull requests to start to be reviewed.

Describe the changes this pull request includes

Does your pull request pass the netlify/pyladies-elections/deploy-preview check?

Pull Request Checklist

/cc @pyladies/tech-and-infra-admins

lorenanicole commented 4 years ago

@deboraazevedo make sure when you make your feature branch to always:

git pull origin main
git checkout -b FEATURE_BRANCH

You'll notice originally the netlify preview was failing, that's because your local branch appears to not be based off the latest main code which has the runtime.txt file. We need that to specify to netlify that we are using Python 3.7, otherwise the Netlify preview will fail when it attempts to install the Python dependencies that are only for Python 3.X.

I pulled down your local branch and push up a merge main commit to prompt the rebuild and allow netlify to run.

Additionally that's why we have the template checklist, so please do use this to help us review PRs: image

lorenanicole commented 4 years ago

Now that the preview is building it tentatively LGTM!

Upon reviewing the pages, though, I am a little concerned about the slug for this page though -- https://deploy-preview-38--pyladies-elections.netlify.app/pt/pages/conselho%20global.html. I'd rather if we can rename the cohselho_global as the slug. Having a space in the URL is a bit awkward.

If you want to change that here: https://github.com/pyladies/pyladies-elections-website/blame/main/content/pages/pt/council.md#L7.

lorenanicole commented 4 years ago

@deboraazevedo you should be good to merge this!

deboraazevedo commented 4 years ago

And it's done!