pyladies / pyladies-elections-website

Code for http://elections.pyladies.com

http://elections.pyladies.com

MIT License

6 stars 7 forks source link

Arabic translation #46

Closed elateifsara closed 4 years ago

elateifsara commented 4 years ago

PyLadies Pull Request

Please document the following. We will aim to be as timely as possible in processing your pull request, however as this is a volunteer staffed project anticipate at least a week for pull requests to start to be reviewed.

Describe the changes this pull request includes

Arabic translation of files in content/pages/en

Does your pull request pass the `netlify/pyladies-elections/deploy-preview` check?

[ ] Yes
[ ] No

Pull Request Checklist

[x] Fill out all sections above
[x] Share pull request in PyLadies Slack channel #project-tech-infra

/cc @pyladies/tech-and-infra-admins

BethanyG commented 4 years ago

@elateifsara -- Pinged you on Slack, but am also leaving a note here. This PR says that there have been 507 files changed. To my knowledge, you should only have 7-11 (maybe 12) files changed (since it should only be the files you translated). Looking at the files, it appears that you checked in your virtual environment activate scripts and installed python libraries -- which we don't want in the repo.

Unfortunately, I don't think I can fix that from my side, so I think you might need to remove those files from your branch commit and update the PR with only the files you've changed. Let myself or @lorenanicole know if you run into issues and need help.

BethanyG commented 4 years ago

@elateifsara -- anything under /output/ should also be omitted, since the site is re-generated from the .md files after we merge to main. Apologies. can you remove those as well, please?