pylerSM / XInstaller

[Xposed module] Various tweaks for Package Installer
http://repo.xposed.info/module/com.pyler.xinstaller
BSD 2-Clause "Simplified" License
152 stars 61 forks source link

CoolDroid changes for verifySignatureHook #22

Closed cooldroid closed 9 years ago

cooldroid commented 9 years ago

Working well for me. Please review and incorporate if you don't see any issues.

pylerSM commented 9 years ago

I will check this. If I understand correctly, system will just return true and original method will NOT be called. Right?

Maybe we can fully replace such method. (using replaceMethod). It would be same as this, just we would do it using Xposed API.

What do you think?

pylerSM commented 9 years ago

^Hm, we cant replace some methods like this since system needs return value when X option is disabled.

I will test your patch tomorrow.

cooldroid commented 9 years ago

Yes you correct, replacing the method would cause issue if the option is disabled.

pylerSM commented 9 years ago

And what about your patch? if option is disabled, I have no idea what will be returned. Just nothing or?

cooldroid commented 9 years ago
            if (isModuleEnabled() && verifySignature) {
                param.setResult(true);
                return;
            }

If the option is disabled the module will continue normally. the "return" statement is inside the module enabled/disabled check.

pylerSM commented 9 years ago

Right. Merged.

cooldroid commented 9 years ago

Seems that this merge has been overridden by a recent commit. :)

pylerSM commented 9 years ago

Fixed :)