search

pylerSM / XInstaller

[Xposed module] Various tweaks for Package Installer
http://repo.xposed.info/module/com.pyler.xinstaller
BSD 2-Clause "Simplified" License
152 stars 61 forks source link

Fixed "Showing buttons when obscured" #36

Closed mattiamaestrini closed 8 years ago

mattiamaestrini commented 8 years ago

Unfortunately hook onFilterTouchEventForSecurity in the android package is not enough to enable the buttons when an overlay is displayed.

This commit enables the buttons that have the attribute android:filterTouchesWhenObscured="true" in the packages com.android.packageinstaller and com.android.backupconfirm.

pylerSM commented 8 years ago

Thank you..

We should "enable" it for all apps, not just Settings and Package Installer. So just simply fix this commit.

easyaspi314 commented 8 years ago

As a sub-checkbox. We wouldn't want it to be an all-or-nothing thing. Especially when it comes to SuperSU and stuff.

– Devin Hussey

On Wed, Dec 16, 2015 at 2:01 PM, pyler notifications@github.com wrote:

Thank you..

We should "enable" it for all apps, not just Settings and Package Installer. So just simply fix this commit.

— Reply to this email directly or view it on GitHub https://github.com/pylerSM/XInstaller/pull/36#issuecomment-165210920.

mattiamaestrini commented 8 years ago

I don't see why this should "enable" it for all apps. XInstaller is a module to tweaks the Package Installer, not a system wide module.

I close my PR, sorry to bother you.