search

pylerSM / YouTubeBackgroundPlayback

[Xposed module] Enable background playback in YouTube
http://repo.xposed.info/module/com.pyler.youtubebackgroundplayback
BSD 3-Clause "New" or "Revised" License
313 stars 81 forks source link

General NOT WORKING etc. thread... #336

Closed LRX22G closed 6 years ago

LRX22G commented 7 years ago

Can you upload anywhere else?

lobezno223 commented 7 years ago

+1

th3an7 commented 7 years ago

I think the only way to share it, is through some personal cloud storage...

In case someone needs an apk of a module... I'll leave it here

LodanZark commented 7 years ago

There is no build bots?

th3an7 commented 7 years ago

Nope... Why would you need that if every update for YouTube app is made on GitHub and then sent straight to your phone?

There are no changes in app source code beside hooks which are downloaded remotely.

On Thu, Jul 20, 2017, 21:22 LodanZark notifications@github.com wrote:

There is no build bots?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/336#issuecomment-316804340, or mute the thread https://github.com/notifications/unsubscribe-auth/AMxxbKzdM4vsa8aqK6GoMCQHgVOGiNewks5sP6jhgaJpZM4OdDWG .

sigv commented 7 years ago

Anybody know what actually happened and why it is no longer on the Xposed Repo?

iHelp101 commented 7 years ago

One of the other developers can choose to explain the matter further, but I will let you know it was not a developer that removed it. Overall, I think you can guess why the module was removed.

LodanZark commented 7 years ago

Because allow to adquire a paid feature for free...

lobezno223 commented 7 years ago

I think the main question current users of this module have is if we can continue updating yt app automatically with no worries...

thrdroom commented 7 years ago

@iHelp101 -.- why the mystification of any real information? At all the DEVs: Just tell the people all the reasons upfront! Whats the matter of being 100% transparent, god damn?! Why was it removed, and who pressured the removing?

th3an7 commented 7 years ago

@thrdroom Breaking ToS... I guess you can figure out the rest...

Since you know everthing now I can edit this comment...

COMMENT EDITED CAUSE I LIKE THAT MYSTERY :)

thrdroom commented 7 years ago

@th3an7 Thanks a lot for the clarification. Well, thats sad to hear :( so where to go now? Any chance of getting this project keep going without the need of xposed? Any ideas of how to avoid getting punished by google the same way?

iHelp101 commented 7 years ago

@thrdroom In terms of why I was "mysterious" about the situation it is because takedown request can be confidential in some cases. Especially since it was sent to another party and relayed to us. I have mentioned to the other developers that Google gave a slap on the wrist with this. If Google wants to they will just takedown the GitHub as well in the future. In the end Google doesn't like what the module does.

You can go the smali hacking route, but distributing an APK that has been smali hacked/modified would be distributing all of Google's code and copyrighten images, which is going to get one in even more trouble compared to the slap on the wrist in this case.

th3an7 commented 7 years ago

You know... The sources are still here - everyone can build an apk for themselves. The main problem is, if somehow Google will get to know that we are still updating the sources, they could force to delete them too - that's what we want to avoid for now.

I think users should learn to update and build the module themselves... It's really not that hard - you just need to know what to search for :) It takes me max. 10 minutes to update all the sources (original & fork + 1 branch)

On Mon, Jul 24, 2017, 14:23 thrdroom notifications@github.com wrote:

@th3an7 https://github.com/th3an7 Thanks a lot for the clarification. Well, thats sad to hear :( so where to go now? Any chance of getting this project keep going without the need of xposed? Any ideas of how to avoid getting punished by google the same way?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/336#issuecomment-317405497, or mute the thread https://github.com/notifications/unsubscribe-auth/AMxxbJ3C0fOzxzGzaCmNqyKZOABQyRhEks5sRIywgaJpZM4OdDWG .

th3an7 commented 7 years ago

There is even a tutorial I've made some time ago... just please, mute the video and turn on CC for English subs :P

Lightfire228 commented 7 years ago

So, the next question is, will this repo be updated after each release? I just read the tutorial on Xposed modules by rovo, so I don't think it would be too hard to do this on my own with this repo as a base.

Heck, I'm still stuck on YT 12.15.55 for YT adblock

th3an7 commented 7 years ago

Maybe I will update it when new version is released... but won't promise anything :)

On Wed, Jul 26, 2017 at 2:13 AM Lightfire228 notifications@github.com wrote:

So, the next question is, will this repo be updated after each release? I just read the tutorial on Xposed modules by rovo, so I don't think it would be too hard to do this on my own with this repo as a base.

Heck, I'm still stuck on YT 12.15.55 for YT adblock

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/336#issuecomment-317909458, or mute the thread https://github.com/notifications/unsubscribe-auth/AMxxbL0u9wYGo3PtiprGogAr8q95Rgchks5sRoS0gaJpZM4OdDWG .

climatesultan commented 6 years ago

I would want to know that, can you update the module for us in the future.?

climatesultan commented 6 years ago

And is there anyway that you can distribute it to us.? Without Google catching in. Background play is my favorite module. For which I installed Xposed..

th3an7 commented 6 years ago

As I said before - if they won't change much, I'll try to update it. About distribution - personally, I don't know... I guess there could be "rain" from my personal cloud (if you know what I mean :P)

On Fri, Jul 28, 2017 at 4:28 AM gokulraj3 notifications@github.com wrote:

And is there anyway that you can distribute it to us.? Without Google catching in. Background play is my favorite module. For which I installed Xposed..

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/336#issuecomment-318539267, or mute the thread https://github.com/notifications/unsubscribe-auth/AMxxbPip16e7EA-Yvv-Y0ZWbfydb-i38ks5sSUdUgaJpZM4OdDWG .

Lightfire228 commented 6 years ago

Since we're all on github, I assume we're all devs. We can just compile the apk from source using Android Studio. That's what I did to my newly rooted Kindle Fire. I feel like that would be safer, since Google can't claim the apk is being distributed. (just my opinion though. I've not had to deal with legal stuff like this before)

terrorist96 commented 6 years ago

Is there something we can subscribe to in order to get notified of new updates for this module?

Vednix commented 6 years ago

https://infinityssh.ddns.net/ytbp/ Debug Apk + Release Apk + Source Gradle (AS)

KimJiSung1 commented 6 years ago

@Vednix it doesn't work

th3an7 commented 6 years ago

@KimJiSung1 uninstall the one you have now (if you have one ofc)

KimJiSung1 commented 6 years ago

@th3an7 It worked, thanks

ghost commented 6 years ago

Been using this module for a long time, and it being taken down is a tragedy, besides, thank you so much for it and for sharing it again

cgarz commented 6 years ago

This is really terrible. Youtube neglects to impliment background play for years to the point people were patching the apk and redistributing it. Then xposed made the whole process easier and without breach of copyright. Then years later youtube decides to copy this modules idea. But ONLY for extra money. And somehow this module is in the wrong?! and was told to be taken down?! Is there anywhere we can tell them just how dispicable they are? Or a petition to overturn this spiteful atrocity? I wish them all the worst in life.

climatesultan commented 6 years ago

hey, can make this app for without root and without xposed. is it possible?

th3an7 commented 6 years ago

@gokulraj3 I guess only by modifying YT app itself... but you won't be able to login to your account

climatesultan commented 6 years ago

@th3an7 THanks for the reply.. i think you are correct. but having a app like that also will be cool too..

climatesultan commented 6 years ago

The YouTube app got updated, please help me .. the module stopped working in in my phone after the new update.

th3an7 commented 6 years ago

I've just updated the sources... It should work now...

Force close YT/reboot your phone :)

On Wed, Aug 23, 2017, 15:27 gokulraj3 notifications@github.com wrote:

The YouTube app got updated, please help me .. the module stopped working in in my phone after the new update.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/336#issuecomment-324330560, or mute the thread https://github.com/notifications/unsubscribe-auth/AMxxbI5-16sv0hB_elhEVPAPYufJNvnAks5sbCipgaJpZM4OdDWG .

climatesultan commented 6 years ago

@th3an7 thanks so much..

rmenessec commented 6 years ago

@th3an7,

Why isn't this posted in the Releases section? GitHub provides homepage hosting, wiki hosting, binary release storage...

Compare: NewPipe YT player project.

LodanZark commented 6 years ago

@rmenessec probably to keep the updates more low profile to avoid getting the risk of this repo being removed from github...

rmenessec commented 6 years ago

@LodanZark Then it's probably a very bad idea to host builds via Google Drive, too.

I'm confused about the legal situation; what theory were Google / YouTube operating under when they made the initial threat? IANAL, but: Reverse-engineering is explicitly allowed under the terms of the US DMCA... assuming the developer is in the US to begin with. It would be a violation of the DMCA to file a DMCA claim against the GitHub project, or any other hoster, because there's no actionable copyright violation in progress.

(Unless the module is actually using Google's code. That would be infringement.)

For the sake of argument: if the developer is violating the YouTube EULA, that's still not a basis for a DMCA takedown claim.

th3an7 commented 6 years ago

@rmenessec we're not changing .apk so much, only the code for supporting YT app... Module was removed from Xposed Repo, we don't want it to be removed from GitHub too.

Also, that Drive is my private cloud so... let's say it's not "official" release :)

LodanZark commented 6 years ago

@rmenessec Not exactly, making the binary available in the project page notifies the followers of the repo, plus makes it easier to share the "official" download links which calls more attention than someone shares compiled files from the google drive personal links

LodanZark commented 6 years ago

th3an7 was more faster to reply than myself xD

dakotagrvtt commented 6 years ago

@rmenessec Maybe try Mega too?

Sent from my Oneplus A0001 using FastHub

rmenessec commented 6 years ago

@dakotagrvtt

@rmenessec Maybe try Mega too?

Sorry, I don't understand. This doesn't address the points I made. See my edited comment above.

If Google really have a problem with this project, changing a hosting provider won't make much difference. Changing how notifications are provided won't do much, either. If YTBP is using parts of Google's code—I assume this is NOT the case—it needs to be rewritten not to.

If Google doesn't have any real legal basis for objecting to YTBP... which I suspect is the case... it shouldn't matter where the project is hosted.

th3an7 commented 6 years ago

@rmenessec the problem is, module itself does not have G's YT app code - it connects to it through Xposed and thus modifying it allowing to get paid content for free - background playback is a part of YT RED subscription.

Nobody would like to have is paid content be free by using hacks, right? That's why they issued take down from Xposed repo with all that breaking ToS stuff.

rmenessec commented 6 years ago

@th3an7,

Nobody would like to have is paid content be free using hacks, right? That's why they issued take down from Xposed repo with all that breaking ToS stuff.

I understand that reason, yes. But that's not a legal basis for threatening you or other developers. If the threat was over an EULA, I can't advise you on that. (IANAL) I can state with reasonable certainty, though, that they can't issue a (valid) DMCA takedown against the GitHub project if you're not infringing a copyright held by Google. You're not copying or otherwise redistributing their software, so it looks to me like there's no possibility of infringement.

If you want to get rid of the showdown over the EULA, though, and if the threat is specifically against the YouTube app's EULA and not the service, then you may want to change your approach altogether. Instead of modifying the app—I think Google are very wrong to worry about whether you're changing a temporary copy in memory, but that's me—you may want to wander over to the NewPipe project and ask what you can do to help them reach a 1.0 release.

... That, or work on your own project using entirely third-party software, instead of altering the behavior of the YouTube app. There's not a lot they can complain about if you do work on software that's 100% yours... or at least 100% not theirs. 😉

terrorist96 commented 6 years ago

@rmenessec What you say is probably correct. However, just because what you are doing is not illegal doesn't mean you can't be arrested, prosecuted, fined and imprisoned for not breaking the law. Look at Megaupload as a perfect example. On the surface, it was no different than Google Drive or Dropbox. But they got shut down, raided, arrested, assets forfeited, and been fighting a legal war for over five years now, and still haven't been convicted of anything yet. And I doubt the people maintaining this project have the resources of Kim Dotcom to put up a fight where they may be in the legal right. Invalid DMCA notices are sent all the time and are complied with, and the consequences for invalid DMCA notices are rarely enforced.

cgarz commented 6 years ago

I see. I didn't think YTBP was at fault but the discussion on legality here has further convinced me. They really are dispicable then. I've seen blatant abuses like this in other places where organizations try their luck. Large widespread public outcry can help. We really should petition or something. Maybe even ask EFF or similar if you have a good case against them that you could hit them with.

Meneerdaniel commented 6 years ago

Hey, I noticed it wasn't working properly anymore. What do I need to do to get it working again? The version that is still on my phone(Xposed method) is 2.0.4. I'm not a developer so I have no idea what to do know. Help would be greatly appreciated!

th3an7 commented 6 years ago

Which version of YT app do you have? If it's today's update, it should work again. I've already updated it. Try force closing YT app or reboot your phone

On Tue, Aug 29, 2017 at 8:42 PM Meneerdaniel notifications@github.com wrote:

Hey, I noticed it wasn't working properly anymore. What do I need to do to get it working again? The version that is still on my phone(Xposed method) is 2.0.4. I'm not a developer so I have no idea what to do know. Help would be greatly appreciated!

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/336#issuecomment-325757127, or mute the thread https://github.com/notifications/unsubscribe-auth/AMxxbFYXjbqnj0BKKNoA6DobUs2tiokNks5sdFt6gaJpZM4OdDWG .

Meneerdaniel commented 6 years ago

O yeah you're right. I didn't do a reboot. Thanks! Great tool/app!

MolotovCherry commented 6 years ago

I didn't see/know that @th3an7 updated and built his module regularly. So I built my own copy. I also changed the versioning to include the specific git commit it was built from (very useful imho). Just leaving this here anyways.

P.S. Apk is for 12.32.60, commit 35c8137

xkillerz commented 6 years ago

@th3an7 You can build apk and upload it to github as "release". Try it!