pylerSM / YouTubeBackgroundPlayback

[Xposed module] Enable background playback in YouTube
http://repo.xposed.info/module/com.pyler.youtubebackgroundplayback
BSD 3-Clause "New" or "Revised" License
315 stars 81 forks source link

General issue reports vol. 2 #357

Closed terrorist96 closed 5 years ago

terrorist96 commented 6 years ago

Been getting constant crashes in YouTube recently. Haven't tested without this module yet but thought I'd provide this log in case it helps.

java.lang.RuntimeException: An error occurred while executing doInBackground()
    at android.os.AsyncTask$3.done(AsyncTask.java:309)
    at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
    at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
    at java.util.concurrent.FutureTask.run(FutureTask.java:242)
    at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
    at java.lang.Thread.run(Thread.java:818)
Caused by: java.lang.ClassCastException: alyl cannot be cast to javax.net.ssl.HttpsURLConnection
    at com.pyler.youtubebackgroundplayback.YouTubeBackgroundPlayback$HooksDownloadTask.doInBackground(YouTubeBackgroundPlayback.java:266)
    at com.pyler.youtubebackgroundplayback.YouTubeBackgroundPlayback$HooksDownloadTask.doInBackground(YouTubeBackgroundPlayback.java:253)
    at android.os.AsyncTask$2.call(AsyncTask.java:295)
    at java.util.concurrent.FutureTask.run(FutureTask.java:237)
    ... 4 more
sigv commented 6 years ago

Strange case.

What manufacturer and Android version is this? Are you running some other Xposed modules that do something with your networking?

sigv commented 6 years ago

@th3an7 Mind rebuilding the APK?

th3an7 commented 6 years ago

Not at all @sigv ... will do it right away :D

th3an7 commented 6 years ago

Sorry it took me so long... f***** Android Studio trolled me for 3h straight with Gradle syncs errors...

BUT HERE THEY ARE:

Also, if it doesn't want to install, report it so I'll make one change :P

terrorist96 commented 6 years ago

What manufacturer and Android version is this?

Nexus 6p 6.0.1

Are you running some other Xposed modules that do something with your networking?

Running YouTube AdAway too. Also, I've since upgraded to a Note 8 without root/xposed, so I'm of no help in troubleshooting this further.

sigv commented 6 years ago

Well, this change should deal with the issue for anyone else who might have experienced this. 🤷‍♂️ Thanks for reporting anyhow.

sigv commented 6 years ago

Closing as this can be moved over to that big thread I think.

sigv commented 6 years ago

@th3an7 ..or do you want to keep this ticket open and close that one?

th3an7 commented 6 years ago

Maybe we should leave this open and close #336 as it has 170 posts and it starts to lag when I open that issue :D

Also @sigv did you see my latest commits regarding gradle? Are they OK or it should be reverted?

sigv commented 6 years ago

did you see my latest commits regarding gradle? Are they OK or it should be reverted?

Pushed ff3629dd6b9474c6e5e49d1c94714192cf7474fe on top, but looks good. Honestly was too lazy to look into it. Thanks! 👍

Electricity2015 commented 6 years ago

Hi,I have a question ,what to do to see the notification when I am in app, not just in background? (Android 7)

th3an7 commented 6 years ago

Well @Electricity2015... I'm afraid nothing... It's controlled by YouTube app and not by module - the only one who can change that is Google...

But there was module version with changed hooks that showed notification all the time - I've stopped updating them as only few people knew about it - I could try updating it again and recompile new .apk for you to check if the method is still working :P

EDIT: Try this one HERE - there was a lot of changes since I've looked at it last time - I wouldn't have high hopes about that but still... if you wanna test it - go ahead and install that one :)

EDITING THIS TO AVOID CONFUSION

DO NOT INSTALL THIS VERSION - USE https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/357#issuecomment-379087066

Electricity2015 commented 6 years ago

I tried it and doesn't work at all neither in the background ,at least for me.

th3an7 commented 6 years ago

@Electricity2015 Forgot to ask one thing which might solve "not working at all" problem - which YT version are you using? I've modified that module so it "should" work with the latest 13.18.54 version...

If you're below it, grab updated apk from apkmirror and test that module again :P

Electricity2015 commented 6 years ago

Now it is working but still not when YouTube is opened

sersimovi commented 6 years ago

Not working at all with the latest update (13.18.55). Tried with the apk you shared 2 days ago, still not working.

th3an7 commented 6 years ago

@Electricity2015 Then I can't do anything - just roll back to previous version :P

@sersimovi I've updated the module for 13.18.55 - roll back to previous version (not that from 2 days ago) - it should work again…

bestmjh47 commented 6 years ago

After updating to the latest version of youtube, your module constantly crashes youtube. Tested on Android 6.0.1 and 7.0.2. After deactivating your module, the problem has gone but I couldn't get background musics anymore. Do you have any idea why this happens?

Zralle commented 6 years ago

Same here... youtube keeps crashing... I've been using this module for a long time and it worked but since last month I think youtube crashes. I can get yt to work after clearing data but if I close it, it keeps crashing.

Electricity2015 commented 6 years ago

Uninstall ,download module again and install ,for me worked.

sersimovi commented 6 years ago

Wow it worked my dude, thank you Electricity2015

ghost commented 6 years ago

Youtube Cakground Playback version 2.0.5. Android 8.1.0, Magisk 16.0, Xposed 90.2-beta3 systemless. Youtube version 13.20.52. Have reinstalled the module but it stopped working after update. I hope it is possible to fix (again). All the best!

th3an7 commented 6 years ago

@kurci2 13.20.52 is not yet added... I'll update module as soon as new YT .apk is available on apkmirror...

Alternatively you could upload it somewhere to make whole process a lot faster :)

ghost commented 6 years ago

@th3an7, tkank you for your reply. I did not know that you need the apk. Here is the link of the Youtube 13.20.52 apk extracted from my phone - Google Drive (edit: link removed). Hope it helps.

th3an7 commented 6 years ago

@kurci2 yes, thanks for that - I've updated hooks and the module should work again now - try force closing YT app and/or reboot your device

ghost commented 6 years ago

@th3an7, no problem and thank you. I can confirm that the module works again, also thank you for updating your apk files.

ghost commented 6 years ago

Stopped working again on Youtube 13.20.53. Do you think that it is a cat and mouse game and it is best to just disable automatic updates?

th3an7 commented 6 years ago

@kurci2 - yeah... It's probably the best option - we have to update sources everytime new YT apk appears - if we won't do that, module won't work (like this time again)...

Just hold on with YT updated for like 2-3 days when it gets released

ghost commented 6 years ago

@th3an7, thank you for explanation. Will do that. Hope you do not lose patience on this 😄.

th3an7 commented 6 years ago

Not a problem :)

BTW: if you have new apk, could you upload it again? Thanks :)

On Wed, May 30, 2018, 16:30 kurci2 notifications@github.com wrote:

@th3an7 https://github.com/th3an7, thank you for explanation. Will do that. Hope you do not lose patience on this 😄.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/357#issuecomment-393184282, or mute the thread https://github.com/notifications/unsubscribe-auth/AMxxbJ5bnG-dBE44w0aUoUDNTmCn6Ukuks5t3q0BgaJpZM4SPNGx .

ghost commented 6 years ago

@th3an7, here you go - Google Drive.

th3an7 commented 6 years ago

@kurci2 should work again :)

quangtaiqn commented 6 years ago

The app does not work in the latest version of YouTube (13.23.59) @th3an7

th3an7 commented 6 years ago

@quangtaiqn Fixed - force close YT app or reboot your device :)

kevinmustaqim commented 6 years ago

Version 2.0.5 for Android 5.0+ working well on YTv13.23.59

truquete commented 6 years ago

is there any kind soul who could send me the module or a link? I am not familiar with building for android. Thanks

ghost commented 6 years ago

@truquete: https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/357#issuecomment-379087066

th3an7 commented 6 years ago

@sigv could you look at this?

07-21 01:44:27.047 20915 20915 E AndroidRuntime: FATAL EXCEPTION: main
07-21 01:44:27.047 20915 20915 E AndroidRuntime: Process: com.google.android.youtube, PID: 20915
07-21 01:44:27.047 20915 20915 E AndroidRuntime: java.lang.IllegalArgumentException: Cannot hook interfaces: public abstract boolean abyx.c()
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at de.robv.android.xposed.XposedBridge.hookMethod(XposedBridge.java:207)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at de.robv.android.xposed.XposedHelpers.findAndHookMethod(XposedHelpers.java:187)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at de.robv.android.xposed.XposedHelpers.findAndHookMethod(XposedHelpers.java:260)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at com.pyler.youtubebackgroundplayback.YouTubeBackgroundPlayback.hook(YouTubeBackgroundPlayback.java:263)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at com.pyler.youtubebackgroundplayback.YouTubeBackgroundPlayback.access$400(YouTubeBackgroundPlayback.java:41)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at com.pyler.youtubebackgroundplayback.YouTubeBackgroundPlayback$HooksDownloadTask.onPostExecute(YouTubeBackgroundPlayback.java:347)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at com.pyler.youtubebackgroundplayback.YouTubeBackgroundPlayback$HooksDownloadTask.onPostExecute(YouTubeBackgroundPlayback.java:274)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at android.os.AsyncTask.finish(AsyncTask.java:651)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at android.os.AsyncTask.access$500(AsyncTask.java:180)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:668)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at android.os.Handler.dispatchMessage(Handler.java:102)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at android.os.Looper.loop(Looper.java:152)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at android.app.ActivityThread.main(ActivityThread.java:5497)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at java.lang.reflect.Method.invoke(Native Method)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
07-21 01:44:27.047 20915 20915 E AndroidRuntime:    at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:107)

Reported HERE on XDA - the device is OnePlus 2 with systemless Xposed v89...

ghost commented 6 years ago

doesn't work with latest update (13.29.53) :)

th3an7 commented 6 years ago

@man0usos does it crash or it doesn't work at all? The hooks are updated so it should work...

Post logcat and xposed logs please

ghost commented 6 years ago

@th3an7 it "magically" started working again after messing around(reinstalling ytb app and module etc) thanks.

th3an7 commented 6 years ago

@man0usos after every update of YT app, hooks are updated here so you don't have to install new module .apk everytime new YT gets released...

The one thing you need to do is to reboot your device or force close youtube app - this will force hooks to be downloaded - just make sure they are updated (there will be commit with supported YT version like this one https://github.com/pylerSM/YouTubeBackgroundPlayback/commit/bb3f3a7e2c323de8fe61d15fec4148ace446eb51)

jabarel commented 6 years ago

@th3an7 the YouTube it's crashing....cannot open it can you check please I'm on oxygen os 5.1.6 Oreo with system less Xposed ....YouTube version 13.39.51 and module it's 2.0.5

th3an7 commented 6 years ago

@jabarel hmm... are you using adaway or something similar? Check logcat and xposed logs for any errors...

jabarel commented 6 years ago

@jabarel hmm... are you using adaway or something similar? Check logcat and xposed logs for any errors...

i uninstall all modules.....seems the youtube adway crashing things and its not youtube play in background problem :D sorry thanks for your tips

AuroraWright commented 5 years ago

13.41.53 is out on the store and it's not supported (as expected as 13.41.52 is the last update I guess, just letting you know)

th3an7 commented 5 years ago

@AuroraWright I know, and as I said already on XDA HERE I think I, myself, will be switching to either weekly or 2 weeks hooks updates...

There were a lot of new YT app updates (new version every 3 days) + new beta updates (which I'll be skipping completely I guess)...

Since I am still the only one who's updating hooks, I don't have that much time and resources to sit here and update this repo every day...

Also I think lots of people switched to YouTube Vanced already and this module is not as popular and used as much as it was before

But if users still want this module to be updated, I'll try to maintain current state... Let me know what you (and rest of users) think about it...

AuroraWright commented 5 years ago

How do you update hooks? Is it manual (apktool/comparing versions etc) or with a script? And in the former case, is it something that can be feasibly automated?

th3an7 commented 5 years ago

I am doing everything manually - decompiling app, comparing with previous version and updating hooks based on that...

If you look at previous version and compare it with the latest one, you'll see the classes haven't changed - only their place have been switched... This can be easly verified as HEX code of each one is basically the same (I think that's the fastest way to find the classes)...

It takes maximum of 5 minutes to find all the classes and update hooks here, but since the updates are released too frequently, skipping some of them would be OK as hooks files are getting bigger and bigger with each version - I would drop support for some super old versions but I don't know how old versions are still in use...

I will update hooks for 13.41.53 and the module should work again in ~1h (as classes are probably the same, we're just missing version number for .53)

I'll be observing further updates - if they will be still released every 3 days, I will skip them and wait for response from either You or some other user - that way hooks would be still updated and files wouldn't be so big as they already are...

th3an7 commented 5 years ago

@AuroraWright It should work once again - restart your device or force close YT app :)