A the moment max_iter gives the numbers of re-iterations for the global corrections. That means a value of 0 is zero re-iterations and one correction iteration. This is very confusing.
Possible Implementation
IMHO it should be renamed to iterations and 1 means single iteration corrections, while everything above means more iteration steps.
If we don't change it now (while I am also implementing the connection to the GUI), we will never change it. Any objections?
@lmalina @awegsche @fsoubelet @Mael-Le-Garrec ?
JoschD
commented
1 year ago
Feature Description
A the moment
max_itergives the numbers of re-iterations for the global corrections. That means a value of0is zero re-iterations and one correction iteration. This is very confusing.Possible Implementation
IMHO it should be renamed to
iterationsand1means single iteration corrections, while everything above means more iteration steps.If we don't change it now (while I am also implementing the connection to the GUI), we will never change it. Any objections? @lmalina @awegsche @fsoubelet @Mael-Le-Garrec ?