search

pylhc / omc3

Python 3 codes for beam optics measurements and corrections in circular particle accelerators
https://pylhc.github.io/omc3/
MIT License
14 stars 7 forks source link

Check Corrections #413

Closed JoschD closed 1 year ago

JoschD commented 1 year ago

Implements the feature of checking corrections and their influence on the optics via MAD-X and plotting the expected results.

JoschD commented 1 year ago

I apologize for the length of this PR... There is no version bump yet, as I want to do the release later, when the GUI itself is ready.

fsoubelet commented 1 year ago

Unrelated but since I saw some ArrayLike instances in there and it relates to #407, I have found the fix for their expansion in the doc pages. It is solved by adding the following in our doc/conf.py:

# This is to tell Sphinx how to print some specific type annotations
# See: https://stackoverflow.com/a/67483317
# See: https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#confval-autodoc_type_aliases
autodoc_type_aliases = {"ArrayLike": "ArrayLike"}

This way they will appear as literally ArrayLike in the documentation.

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 46fe2f08 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 93.2% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.9% (0.5% change).

View more on Code Climate.