Hl fixes - Githubissues

pylhc / omc3

Python 3 codes for beam optics measurements and corrections in circular particle accelerators

https://pylhc.github.io/omc3/

MIT License

13 stars 6 forks source link

Hl fixes #428

Closed awegsche closed 9 months ago

awegsche commented 9 months ago

this adds a couple of fixes related to hl

important phase advances are not yet defined for HL

"The names of tertiaries are different in HL and in general everything in between q5 to Q5 is different. The phase advances for HL are likely different from LHC. We will finalise likely towards oct-nov 2023 after we will perform further optimizations." -- Riccardo De Maria

the response creator used the formatting +f for delta_k, which only printed exactly 6 decimal spaces. consequently, values below 1e-6 were written as 0 into the job file.

awegsche commented 9 months ago

how does this change break plotting?

fsoubelet commented 9 months ago

Seems like a new version of matplotlib stopped accepting use_line_collection kwarg: https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.8.0.html#parameters-to-plt-figure-and-the-figure-constructor.

@JoschD can you have a look when you've got time?

codeclimate[bot] commented 9 months ago

Code Climate has analyzed commit 595c6183 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 75.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.8%.

View more on Code Climate.