search

pylhc / omc3

Python 3 codes for beam optics measurements and corrections in circular particle accelerators
https://pylhc.github.io/omc3/
MIT License
14 stars 7 forks source link

Fix pandas indexing error #434

Closed Mael-Le-Garrec closed 7 months ago

Mael-Le-Garrec commented 7 months ago

The pandas Series has to be converted to a numpy array for the indexing to work. Functionality has been removed after depreciation and leads to an error. Somehow the change has already been made for the function calculate_dpoverp with the ~same code at line 76

codeclimate[bot] commented 7 months ago

Code Climate has analyzed commit c23b9d6b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.0% (0.0% change).

View more on Code Climate.

fsoubelet commented 7 months ago

Thanks! Could you change the version for a patch release @Mael-Le-Garrec ?

fsoubelet commented 7 months ago

Will up the version number in #436