search

pylhc / omc3

Python 3 codes for beam optics measurements and corrections in circular particle accelerators
https://pylhc.github.io/omc3/
MIT License
14 stars 7 forks source link

Some kmod scripts added #438

Open fscarlier opened 7 months ago

fscarlier commented 7 months ago

I added 3 scripts for kmod stuff. They all operate separately with input opts for now, and don't affect omc3 tools. They could be merged in some way later with the GUI I guess. If merged later, we might need to remove the strict=True in the entrypoint

The import_kmod.py scripts is in the corrections dir since that made sense for the global corrections. The others are in the main dir for now, but feel free to suggest better locations.

import_kmod.py : imports kmod results for global corrections kmod_averages.py : calculates averages from multiple kmod measurements, plots betas, and outputs them in a specific dir kmod_lumi**py : calculates the luminosity imbalance between ip1 and ip5

codeclimate[bot] commented 7 months ago

Code Climate has analyzed commit 6405f97b and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 9.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 83.8% (-2.2% change).

View more on Code Climate.

JoschD commented 7 months ago

You branched this off of the total-phase-correction branch. Was that on purpose? This might cause problems later when that branch has been merged to master... would be better to rebase on master

JoschD commented 5 months ago

Hey @fscarlier . This still needs tests, have you progressed in that regard?

JoschD commented 2 months ago

Hey @fscarlier what is the status of these tests? Have you talked to @emaclean or @rogeliotomas that maybe someone else can take over this task if this cannot be done by you?