search

pylhc / tfs

Python package to handle TFS files
https://pylhc.github.io/tfs/
MIT License
9 stars 4 forks source link

[Feature Request]: Speedup Dataframe Validation #108

Closed fsoubelet closed 1 year ago

fsoubelet commented 1 year ago

Feature Description

As reported by some users, the validation step can be very slow on large dataframes (for instance sliced FCC lattice).

In #107 the validation step was made optional. This is a first step but it would be nice for users who wish to validate to be able to do so faster.

Possible Implementation

The main culprit is is_not_finite(x) in the validate function, which is slow and applied with applymap, also very slow.

This can be sped-up (see implementation).

fsoubelet commented 1 year ago

Closed by #109