Don't use None to specify that arguments can't be determined in raw_building

pylint-bot / test

0 stars 0 forks source link

Don't use None to specify that arguments can't be determined in raw_building #222

Closed pylint-bot closed 8 years ago

pylint-bot commented 8 years ago

Originally reported by: Claudiu Popa (BitBucket: PCManticore, GitHub: @PCManticore?)

We should use a special node instead, so that the AST does not contain non-AST nodes.

Bitbucket: https://bitbucket.org/logilab/astroid/issue/222

pylint-bot commented 8 years ago

Original comment by BitBucket: ceridwenv, GitHub: @ceridwen?:

Since I need to fix this, what node should I use?

pylint-bot commented 8 years ago

Original comment by Claudiu Popa (BitBucket: PCManticore, GitHub: @PCManticore?):

Just define something that suggests that it's unknown. Maybe UnknownNode or something similar? This should be ignored by all other operations, such as inference or calling as_string on it. Also, it would be good to be in its own changeset, so that we can track better where it got changed.

pylint-bot commented 8 years ago

Original comment by BitBucket: ceridwenv, GitHub: @ceridwen?:

This is closed by e956e29392a8 and 5fe25086c708, which adds the Unknown node with some stub functions and uses it for non-introspectable signatures.