pylint-dev / astroid

A common base representation of python source code for pylint and other projects
https://pylint.readthedocs.io/projects/astroid/en/latest/
GNU Lesser General Public License v2.1
532 stars 276 forks source link

Fix python 3.13 compatibility re: collections.abc #2598

Closed jacobtylerwalls closed 1 month ago

jacobtylerwalls commented 1 month ago

Type of Changes

Type
:bug: Bug fix

Description

Closes pylint-dev/pylint#10000

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.25%. Comparing base (6dba72c) to head (59a3429). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pylint-dev/astroid/pull/2598/graphs/tree.svg?width=650&height=150&src=pr&token=Buxy4WptLb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev)](https://app.codecov.io/gh/pylint-dev/astroid/pull/2598?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev) ```diff @@ Coverage Diff @@ ## main #2598 +/- ## ======================================= Coverage 93.25% 93.25% ======================================= Files 93 93 Lines 11044 11050 +6 ======================================= + Hits 10299 10305 +6 Misses 745 745 ``` | [Flag](https://app.codecov.io/gh/pylint-dev/astroid/pull/2598/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev) | Coverage Δ | | |---|---|---| | [linux](https://app.codecov.io/gh/pylint-dev/astroid/pull/2598/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev) | `93.14% <100.00%> (+<0.01%)` | :arrow_up: | | [pypy](https://app.codecov.io/gh/pylint-dev/astroid/pull/2598/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev) | `93.25% <100.00%> (+<0.01%)` | :arrow_up: | | [windows](https://app.codecov.io/gh/pylint-dev/astroid/pull/2598/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev) | `93.23% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/pylint-dev/astroid/pull/2598?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev) | Coverage Δ | | |---|---|---| | [astroid/brain/brain\_collections.py](https://app.codecov.io/gh/pylint-dev/astroid/pull/2598?src=pr&el=tree&filepath=astroid%2Fbrain%2Fbrain_collections.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-YXN0cm9pZC9icmFpbi9icmFpbl9jb2xsZWN0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
github-actions[bot] commented 1 month ago

The backport to maintenance/3.3.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/3.3.x maintenance/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/3.3.x
# Create a new branch
git switch --create backport-2598-to-maintenance/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f63a39368dd422d49d77c42a7dd6dad00ee1a986
# Push it to GitHub
git push --set-upstream origin backport-2598-to-maintenance/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/3.3.x

Then, create a pull request where the base branch is maintenance/3.3.x and the compare/head branch is backport-2598-to-maintenance/3.3.x.