Closed irtazaakram closed 9 months ago
Hi @stdedos, can you please review this. Thanks,
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e73cc2f
) 92.03% compared to head (d5c61a8
) 91.96%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The v2.0 I'm estimating to be released mid-November
Setting this as blocked
For the failing actions, you might want to revert b3e8974b729e9dbb2d34cc9ef6c65a0595e1faa6
Hi @stdedos, Thank you for taking time to review this PR. Much appreciated.
Thank you for offering the code @irtazaakram ❤️
hi @stdedos,
do you know what happened here? I see the banner Pull request successfully merged and closed
and it aslo says I closed it even though i never did?
That is ... interesting 😕
All I can see is this
Something-something with your force-pushes, but I must run for now and I haven't checked what happened there 😅
🤦🏻 let me know if i should open a new PR? as I am also not able to reopen it.
I think it should be something obvious we are both missing
Also, GitHub is somewhat too magic sometimes for my taste 😅
hey @stdedos, I mistakenly forced pushed commit without any changes while trying to revert https://github.com/pylint-dev/pylint-pytest/commit/b3e8974b729e9dbb2d34cc9ef6c65a0595e1faa6 🤦🏻 and thats what caused this PR to close.
PR is ready now. Let me know if there are any changes that you want to suggest.
again apologies for this.
Thank you
Hey @irtazaakram
pre-commit says this:
(https://results.pre-commit.ci/run/github/602434841/1698218743.HAiZ2fOQR3-yD9koSvOV5w)
You'd have to either apply the changes, or allow pre-commit to apply those changes 😕
These changes causes tests to fail for python 3.8 & 3.9
https://github.com/pylint-dev/pylint-pytest/actions/runs/6637112680/job/18031541929?pr=22
I will eventually handle some of those pylint issues
The MR looks solid - and we need to figure out a solution for Windows-testing.
Amazing job @irtazaakram 🚀
I can't write directly on this branch but the fix for pylint's check is this: https://github.com/pylint-dev/pylint-pytest/commit/904e2e9b374de865caebde35e2e92a484c54147c
Closing in favor of two other merge requests: #23 then #24. Thank you for your work @irtazaakram I credited you in the rebased commit.
Hi,
This PR
Can we please have a new release after this PR is merged.
Thanks,
Fixes https://github.com/pylint-dev/pylint-pytest/issues/11 Fixes https://github.com/pylint-dev/pylint-pytest/issues/12