Closed Pierre-Sassoulas closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
48212e2
) 94.16% compared to head (f6e9b9e
) 93.97%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@stdedos I think it could be merged even with the negative coverage change.
@stdedos could you review this, please :) ? The CI is red because of an indirect coverage changes that I think we can ignore.
@stdedos could you review this, please :) ? The CI is red because of an indirect coverage changes that I think we can ignore.
Yeah, this seems to be the problem: https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/23/indirect-changes
I'd be nice to figure out why is this happening, but it is definitely not a priority - given the benefits of this PR.
"I am not reviewing this" since it's not scheduled to go in yet. Otherwise all looks golden to me and it is approved 💚
Plan is:
Question:
Can https://github.com/pylint-dev/pylint-pytest/pull/24 become thinner? I could consider it for v1
We can remove the drop of python 3.6 / 3.7 (probably)
Can https://github.com/pylint-dev/pylint-pytest/issues/12 be fixed for v1? I lost track on what was the pylint issue 😅
Need to support 3.12 maybe something else
Can #24 become thinner? I could consider it for v1
We can remove the drop of python 3.6 / 3.7 (probably)
I'd consider it for v1 - but it doesn't have to wait "the usual" 1w-period.
So next week we release master, and a thin #24 afterwards
Hey, I tried dropping the removal of python 3.6 / 3.7 and simply adding python 3.12, but this is non trivial (https://github.com/pylint-dev/pylint-pytest/actions/runs/7010519218/job/19071209667?pr=24). It's been nearly two months since the release of python 3.12 / pylint 3.0 and python 3.6 / 3.7 have been EOL for a long time, maybe we could just drop EOL interpreters and release 2.X serie, what do you think ?
See this issue in vscode/pylint : https://github.com/microsoft/vscode-pylint/issues/460 for example
Thank you for trying ❤️
Sadly, my OSS time has been near-zero these days. I will make it my first priority to merge these.
No problem. This one is ready the coverage drop is acceptable imo.
I took the liberty to prepare this for tomorrow 🙃
Thank you @stdedos :)
Thank you @Pierre-Sassoulas for all your contributions and patience 😁 🙏
Cherry-picked from #8, I'm doing things progressively so it's reviewable.
Closes https://github.com/pylint-dev/pylint-pytest/issues/11