search

pylint-dev / pylint-pytest

A Pylint plugin to suppress pytest-related false positives.
https://pypi.org/project/pylint-pytest/
MIT License
14 stars 3 forks source link

Add `.pre-commit-config.yaml` #4

Closed stdedos closed 10 months ago

stdedos commented 10 months ago

Store all tools' configurations in pyproject.toml, even if right now only the setup.py file is used.

Keep .pylintrc separately. It is 300 lines; default --generate-toml-config gives 600 πŸ˜…

Comment-out hooks that need >0 work to be green.

Signed-off-by: Stavros Ntentos 133706+stdedos@users.noreply.github.com

Enable https://github.com/asottile/pyupgrade + .git-blame-ignore-revs

Signed-off-by: Stavros Ntentos 133706+stdedos@users.noreply.github.com

stdedos commented 10 months ago

@Pierre-Sassoulas here is the .pre-commit-config.yaml. Feel free to extend it, if you wish πŸ™

codecov[bot] commented 10 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6be0547) 86.50% compared to head (ff18b58) 87.00%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4 +/- ## ========================================== + Coverage 86.50% 87.00% +0.50% ========================================== Files 33 33 Lines 400 400 Branches 81 81 ========================================== + Hits 346 348 +2 + Misses 50 48 -2 Partials 4 4 ``` | [Files](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev) | Coverage Ξ” | | |---|---|---| | [tests/base\_tester.py](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-dGVzdHMvYmFzZV90ZXN0ZXIucHk=) | `88.70% <100.00%> (ΓΈ)` | | | [...annot-enumerate-pytest-fixtures/no\_such\_package.py](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-dGVzdHMvaW5wdXQvY2Fubm90LWVudW1lcmF0ZS1weXRlc3QtZml4dHVyZXMvbm9fc3VjaF9wYWNrYWdlLnB5) | `28.57% <ΓΈ> (ΓΈ)` | | | [tests/input/conftest.py](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-dGVzdHMvaW5wdXQvY29uZnRlc3QucHk=) | `71.42% <100.00%> (ΓΈ)` | | | [...ests/input/deprecated-pytest-yield-fixture/func.py](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-dGVzdHMvaW5wdXQvZGVwcmVjYXRlZC1weXRlc3QteWllbGQtZml4dHVyZS9mdW5jLnB5) | `71.42% <100.00%> (ΓΈ)` | | | [tests/input/unused-import/same\_name\_decorator.py](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-dGVzdHMvaW5wdXQvdW51c2VkLWltcG9ydC9zYW1lX25hbWVfZGVjb3JhdG9yLnB5) | `80.00% <100.00%> (ΓΈ)` | | | [...useless-pytest-mark-decorator/not\_pytest\_marker.py](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-dGVzdHMvaW5wdXQvdXNlbGVzcy1weXRlc3QtbWFyay1kZWNvcmF0b3Ivbm90X3B5dGVzdF9tYXJrZXIucHk=) | `78.57% <100.00%> (ΓΈ)` | | | [tests/test\_cannot\_enumerate\_fixtures.py](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-dGVzdHMvdGVzdF9jYW5ub3RfZW51bWVyYXRlX2ZpeHR1cmVzLnB5) | `100.00% <100.00%> (ΓΈ)` | | | [tests/test\_no\_member.py](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-dGVzdHMvdGVzdF9ub19tZW1iZXIucHk=) | `100.00% <100.00%> (ΓΈ)` | | | [tests/test\_pytest\_fixture\_positional\_arguments.py](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-dGVzdHMvdGVzdF9weXRlc3RfZml4dHVyZV9wb3NpdGlvbmFsX2FyZ3VtZW50cy5weQ==) | `100.00% <100.00%> (ΓΈ)` | | | [tests/test\_pytest\_mark\_for\_fixtures.py](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-dGVzdHMvdGVzdF9weXRlc3RfbWFya19mb3JfZml4dHVyZXMucHk=) | `100.00% <100.00%> (ΓΈ)` | | | ... and [9 more](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/4?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/4/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Pierre-Sassoulas commented 10 months ago

WDYM? Remove the sha1 from the file AKA "not-ignore" its blame?

My bad I thougth it was a mistake in a changelog πŸ˜