search

pylint-dev / pylint-pytest

A Pylint plugin to suppress pytest-related false positives.
https://pypi.org/project/pylint-pytest/
MIT License
14 stars 3 forks source link

Use ruff instead of flake8 pyupgrade autoflake and isort #6

Closed Pierre-Sassoulas closed 10 months ago

Pierre-Sassoulas commented 10 months ago

Follow-up to #4 (can wait a new release compatible with pylint 3.0)

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (5ee69ce) 87.00% compared to head (ae436ac) 86.96%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6 +/- ## ========================================== - Coverage 87.00% 86.96% -0.04% ========================================== Files 33 33 Lines 400 399 -1 Branches 81 81 ========================================== - Hits 348 347 -1 Misses 48 48 Partials 4 4 ``` | [Files](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/6?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev) | Coverage Δ | | |---|---|---| | [tests/test\_cannot\_enumerate\_fixtures.py](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/6?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-dGVzdHMvdGVzdF9jYW5ub3RfZW51bWVyYXRlX2ZpeHR1cmVzLnB5) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stdedos commented 10 months ago

Follow-up to https://github.com/pylint-dev/pylint-pytest/pull/4 (can wait a new release compatible with pylint 3.0)

No reason to make code stale, if pre-commit and tests agree. I wanted to start with some scaffolding before doing the first "major" code MRs; these are fine.

Pierre-Sassoulas commented 10 months ago

Ha my bad, the noqa was useless as I fixed it too.

Pierre-Sassoulas commented 10 months ago

(Removed the lock on the master branch from the setting so it could be merged)

stdedos commented 10 months ago

Shouldn't it be there? I must be missing something from Github 😕

Pierre-Sassoulas commented 10 months ago

Locking is locking, it means we can't merge anything. I think protection from push (you can only merge to master after a review) is what we need.